Closed
Bug 478267
Opened 16 years ago
Closed 16 years ago
[FIX]Any time we reflow an nsObjectFrame we assert
Categories
(Core :: Layout, defect, P2)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
FinishAndStoreOverflow asserts that the overflow area contains the frame bounds. The right fix for bug 475723 was to add the call to FinishAndStoreOverflow, not to replace the setting of the overflow area with it.
I guess we need this fixed on the 1.9.1 branch too, right?
Flags: blocking1.9.1?
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #362066 -
Flags: superreview?(roc)
Attachment #362066 -
Flags: review?(roc)
Comment on attachment 362066 [details] [diff] [review]
Fix
Oops, that was stupid of me.
Attachment #362066 -
Flags: superreview?(roc)
Attachment #362066 -
Flags: superreview+
Attachment #362066 -
Flags: review?(roc)
Attachment #362066 -
Flags: review+
Yes, we should take this on 1.9.1.
|
|
Assignee | |
Comment 4•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
|
|
Assignee | |
Updated•16 years ago
|
Attachment #362066 -
Flags: approval1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
|
||
Comment 5•16 years ago
|
||
Comment on attachment 362066 [details] [diff] [review]
Fix
Clearing approval request given blocking1.9.1+.
Attachment #362066 -
Flags: approval1.9.1?
|
|
Assignee | |
Comment 6•16 years ago
|
||
Keywords: fixed1.9.1
Blocks: 479637
Backed out of 1.9.1 since we're backing out bug 475723, which this fixes a regression of. This is still fixed on 1.9.1 because of that backout.
Flags: blocking1.9.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•