Closed Bug 478927 Opened 16 years ago Closed 13 years ago

Need a way from chrome to know when error pages load

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: johnath, Assigned: torisugari)

References

Details

Attachments

(2 files, 1 obsolete file)

Test
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
proposal v1.1
(deleted), patch
Details | Diff | Splinter Review
Whether this means firing DOMContentLoaded on error pages, or inventing some new event that is error-page-specific, it would be extremely helpful to be able to listen for error page loads. It would help with bugs like bug 425001, but also with things like bug 428948
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 623155
Depends on: 673752
Attached patch proposal v1 (obsolete) (deleted) — — Splinter Review
I'm not yet sure this is the right fix for bug 623155, but, in general, it would be useful. >+ * |aWebProgress| does NOT set this flag when it did not try to load a new >+ * contents. In this case, it should set LOCATION_CHANGE_SAME_DOCUMENT. If this behavior is not allowed, probably docshell needs another member variable to store this flag.
Attachment #618640 - Flags: review?(bugs)
Comment on attachment 618640 [details] [diff] [review] proposal v1 This needs tests.
Attachment #618640 - Flags: review?(bugs) → review+
Attached patch Test (deleted) — — Splinter Review
Test, appending to bug 311007's. BTW, during writing the test, I found that my comment for the idl > Both |aURI| and |aRequest| may be null. is a lie. Always aURI is not null. However it can be converted from null to <about:blank> in a very edge case, though I don't know how to reproduce.
Attachment #619197 - Flags: review?(bugs)
Attachment #618640 - Flags: superreview?(bzbarsky)
Comment on attachment 618640 [details] [diff] [review] proposal v1 sr=me
Attachment #618640 - Flags: superreview?(bzbarsky) → superreview+
Attached patch proposal v1.1 (deleted) — — Splinter Review
Fixed IDL comments.
Attachment #618640 - Attachment is obsolete: true
Attachment #619197 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Assignee: nobody → torisugari
No longer blocks: 623155
Blocks: 623155
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: