Closed
Bug 478989
Opened 16 years ago
Closed 15 years ago
Show conversation in tab
Categories
(Thunderbird :: Message Reader UI, defect)
Thunderbird
Message Reader UI
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: davida, Assigned: bwinton)
References
Details
(Keywords: polish, Whiteboard: [has l10n impact])
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
philor
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
Once the gloda-powered tabs land (bug 474701), it'd be a shame not to expose the conversational views.
We need some UX from the message reader to say "show this conversation in a tab, which then opens a tab w/ a thread view of the messages that gloda knows about in that conversation.
Assigning first to bryan for the UX design phase. Then we can find an implementor if bryan doesn't want to do it.
Flags: wanted-thunderbird3+
Comment 1•16 years ago
|
||
depends on bug 474701?
Do UX plan allow for possibility of conversation view in the SAME tab? Reason I ask is I'm wondering if conversation in a separate tab will fit 90% of people's workflow.
Comment 2•16 years ago
|
||
So, this is also about conversation views at all, right, not only about having existing conversation views in tabs?
Comment 3•16 years ago
|
||
In Thunderbird terms this is about opening a single thread in a new tab. When you've archived a thread previously and receive a new message (that is part of that archived thread) Thunderbird won't show the older messages in the thread as they are now in different folders. This bug will allow for people to view the partially archived thread in a new tab.
We're going to have to do some explanation of the above inside the UI itself. I hope we can have some kind of inline method for indicating that there is more of a thread happening than what you see.
So our archived user experience starts like this:
* Person archives an entire thread about Vespa mopeds after reading most messages
* The next day a new message in the Vespa moped thread arrives
* The new message quotes older messages but without the whole thread in view it's hard to understand what is being quoted and why
We could take some space at either the top or the bottom of the message viewport to insert something about how this messages is part of a thread. Even just a simple one line (not using something as loud as the info bar) info bar that offers a button to open the message in it's original thread.
This would require detection of threaded messages, which I don't know if it is possible yet.
Comment 4•16 years ago
|
||
OK, just to get everything right:
* The "in tab" in the bug summary is the least relevant issue in this bug?
* "to archive" refers to moving messages of the thread to any other folder, not just by using the new archive functionality?
Another issue: Please consider showing the folder of the messages of the thread in the conversation view.
Comment 5•16 years ago
|
||
This is the same feature as Postbox's "Show all" button in the message header pane (called "Gather" during beta). It shows a Gmail-style conversation view in a new tab.
http://www.postbox-inc.com/features#viewing
Updated•15 years ago
|
Target Milestone: Thunderbird 3.0b3 → ---
Comment 6•15 years ago
|
||
As a start this would be really easy to add to the ( other actions | v ) button. The only thing we need to do is make sure that gloda is pref'd on or we can't offer this option.
Reporter | ||
Comment 7•15 years ago
|
||
WIP patch which kinda works, except that I'm getting some odd failures on collections failing to find messages that gloda knows about.
Reporter | ||
Comment 8•15 years ago
|
||
(note: I haven't dealt with the listener for gloda preffing off disabling it)
Reporter | ||
Updated•15 years ago
|
Whiteboard: [has l10n impact]
Reporter | ||
Comment 9•15 years ago
|
||
Attachment #400619 -
Attachment is obsolete: true
Assignee | ||
Comment 10•15 years ago
|
||
Here's the first cut.
Thanks,
Blake.
Attachment #400697 -
Attachment is obsolete: true
Attachment #402377 -
Flags: ui-review?(clarkbw)
Attachment #402377 -
Flags: review?(bugmail)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [has l10n impact] → [has l10n impact][needs review asuth][needs ui-review clarkbw]
Comment 11•15 years ago
|
||
Comment on attachment 402377 [details] [diff] [review]
The previous patch, with the menu item disabled sometimes.
looks good!
Attachment #402377 -
Flags: ui-review?(clarkbw) → ui-review+
Updated•15 years ago
|
Attachment #402377 -
Flags: review?(bugmail) → review+
Comment 12•15 years ago
|
||
Comment on attachment 402377 [details] [diff] [review]
The previous patch, with the menu item disabled sometimes.
per IRC the other day you need to be checking the gloda-id property too and should use the constants defined at the top of indexer.js instead of inline strings. Good call on using the proxy helper doodad, I had forgotten about that.
r=asuth with changes.
Assignee | ||
Updated•15 years ago
|
Whiteboard: [has l10n impact][needs review asuth][needs ui-review clarkbw] → [has l10n impact][needs nits fixed]
Assignee | ||
Comment 13•15 years ago
|
||
(In reply to comment #12)
> per IRC the other day you need to be checking the gloda-id property too
I don't remember that, and can't see it in my logs, so I implemented what I think you want, but I'm not going to mark this as checkin-needed until you give it the okay, or davida gets so nervous that he tells me to, or I get bored. ;)
> and should use the constants defined at the top of indexer.js instead of
> inline strings.
Fixed.
> Good call on using the proxy helper doodad, I had forgotten about that.
I had no choice. It was a circular import the other way. :)
> r=asuth with changes.
Thanks,
Blake.
Attachment #402377 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Whiteboard: [has l10n impact][needs nits fixed] → [has l10n impact]
Assignee | ||
Updated•15 years ago
|
Whiteboard: [has l10n impact] → [has l10n impact][waiting until eod-Monday for asuth to comment]
Reporter | ||
Comment 14•15 years ago
|
||
asuth won't be around all of next week, so taking over.
1) you can get rid of my dump/logObject, and use Component.utils.reportError or log4moz instead -- those were just dev debugging prints.
2) the changes to isMessageIndexed look like the conversation _I_ had w/ asuth, so r=davida on that.
Assignee | ||
Comment 15•15 years ago
|
||
Sounds good. I went with Components.utils.reportError, and changed the message to be the slightly-more professional sounding:
"Couldn't find a collection for msg: " + this._msgHdr
:)
Thanks,
Blake.
Attachment #402890 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [has l10n impact][waiting until eod-Monday for asuth to comment] → [has l10n impact]
Updated•15 years ago
|
Attachment #403237 -
Flags: approval-thunderbird3+
Comment 16•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in
before you can comment on or make changes to this bug.
Description
•