get rid of crufty timeline service globals [dead code]
Categories
(MailNews Core :: Backend, task)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
Tracking | Status | |
---|---|---|
seamonkey2.49esr | --- | unaffected |
seamonkey2.63 | --- | wontfix |
seamonkey2.53 | --- | fixed |
seamonkey2.57esr | --- | fixed |
People
(Reporter: davida, Assigned: iannbugzilla)
References
Details
(Whiteboard: [patchlove])
Attachments
(3 files, 6 obsolete files)
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Reporter | ||
Comment 1•16 years ago
|
||
Reporter | ||
Updated•16 years ago
|
Comment 2•16 years ago
|
||
Updated•16 years ago
|
Comment 3•16 years ago
|
||
Reporter | ||
Comment 4•15 years ago
|
||
Comment 5•15 years ago
|
||
Comment 6•10 years ago
|
||
Updated•5 years ago
|
Remove dead code (one global in TB, rest of code in SM)
Patch against older branches
Missed subscribe.js and now includes header
Assignee | ||
Comment 10•5 years ago
|
||
Now includes a header
Assignee | ||
Comment 11•5 years ago
|
||
Rebased against a cleaner tree
Assignee | ||
Comment 12•5 years ago
|
||
Also remove the pref from mailnews.js
Assignee | ||
Comment 13•5 years ago
|
||
Also remove the pref from mailnews.js
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
Touches TB code. I don't see any use there so I suspect dead and gone too. Jork do you want to check this in?
Yes, please. Crufty indeed. Strangely the linter hasn't complained about the unused gTimelineEnabled
.
Updated•5 years ago
|
Comment 18•5 years ago
|
||
Rebased ESR60 version. subscribe.js was removed in Bug 1425962.
jorg could go into 60 if you don't mind. Otherwise we remove the TB part. We don't care currently about 68.
Comment 19•5 years ago
|
||
To me, TB 60 is EOL. We won't ship another version of it. If you want, add a=jorgk.
Since you're only removing dead code, there's no need to backport to 68. I'll land the C-C patch in the next 16 hours (before 12 noon on Monday).
Comment 20•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b0211b821650
get rid of crufty timeline service globals [dead code]. r=frg
Updated•5 years ago
|
Comment 21•5 years ago
|
||
https://hg.mozilla.org/releases/comm-esr60/rev/2fb641eea70251ed955ff49e3a0d85e325f1daac
get rid of crufty timeline service globals [dead code]. r=frg a=frg,jorgk DONTBUILD
Comment 22•4 years ago
|
||
Description
•