Misak Khachatryan Assignee
	Description • 16 years ago

After bug 425480 landing, we get same Firefox behavior - Location bar stays empty when user enters about:blank on new tab. But if you enter about:blank on existing tab with already loaded URL, about:blank shows on location bar.
If Firefox people confirms that bug, it can be moved to toolkit.

Reproducible: Allways

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 1 • 16 years ago

I can't reproduce this in Firefox. about:blank only gets put in the location bar if the window has an opener, are you sure that isn't what you're seeing? SeaMonkey also had that behavior since before bug 425480, though, as far as I can tell...

	neil@parkwaycc.co.uk
	Comment 2 • 16 years ago

Sorry, slight mix-up here. When the window has an opener, we always show about:blank in the location bar. This is correct and has not changed. However, SeaMonkey also used to show about:blank in a tab if that tab had previous history. However if you open about:blank in an existing tab then the location bar goes blank instead of remaining at about:blank which it used to do.

	Misak Khachatryan Assignee
	Comment 3 • 16 years ago

Ok, old if before bug 425480 brings things back. Also I've included fix for typo in patch from bug 425480 Neil pointed.

	neil@parkwaycc.co.uk
	Comment 4 • 16 years ago

Comment on attachment 363133 [details] [diff] [review]
check getWebNavigation().canGoBack too

>-  if (uri.spec == "about:blank")
>-    value = content.opener ? "about:blank" : "";
>+  if (uri.spec == "about:blank" && !getWebNavigation().canGoBack && !content.opener)
>+    value = "";
Well, this works, but you could have added the check in the ?: line instead.

	neil@parkwaycc.co.uk
	Comment 5 • 16 years ago

(In reply to comment #4)
> Well, this works, but you could have added the check in the ?: line instead.
(This refers to an earlier revision of the patch from pastebin which Misak claimed not to work but which worked fine for me...)

	Misak Khachatryan Assignee
	Comment 6 • 16 years ago

Ok, you confused me on IRC ;) It should be getWebNavigation().canGoBack - braces are required, that's why it doesn't work :)

	neil@parkwaycc.co.uk
	Comment 7 • 16 years ago

Comment on attachment 363277 [details] [diff] [review]
like this ?

>+    value = (content.opener || getWebNavigation().canGoBack) ? "about:blank" : "";
              ^                                              ^
Actually it's these ones you don't need. I forgot there were two sets :-(

	Misak Khachatryan Assignee
	Comment 8 • 16 years ago

Now i got it :)

	Serge Gautherie (:sgautherie)
	Comment 9 • 16 years ago

Comment on attachment 363292 [details] [diff] [review]
for checkin
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/f99c51271d92