Closed
Bug 479345
Opened 16 years ago
Closed 16 years ago
Error when submit the setting of Edit Group Access Controls
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: ptmickey, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)
Build Identifier:
The version of the Bugzilla server is 3.3.3+.
After setting the options in the group access control page, click the submit button, then a 500 Internal Server Error is produced.
Reproducible: Always
Steps to Reproduce:
1.Open the Edit Group Access Controls page for any product.
2.Do some change or just left it as original.
3.Click the submit button.
Actual Results:
500 Internal Server Error
Expected Results:
The group access control setting is saved correctly.
Checked the log file of Apache Server (httpd_error.log), found the following output:
[error] Can't call method "group_controls" on an undefined value at /usr/local/www/bugzilla/Bugzilla/Product.pm line 256, <DATA> line 275.\n
|
Assignee | |
Comment 1•16 years ago
|
||
Yes, I can reproduce on tip. 3.2 is not affected.
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking3.4+
Keywords: regression
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.4
Version: unspecified → 3.3.3
|
|
Assignee | |
Comment 2•16 years ago
|
||
Found the culprit. This is a regression due to bug 371995. I have a patch.
Depends on: 371995
|
|
Assignee | |
Comment 3•16 years ago
|
||
Bugzilla::Object->update returns both changes and the old object, but Bugzilla::Field::Choice->update only returns changes, making the caller get an undefined old object.
Assignee: administration → LpSolit
Status: NEW → ASSIGNED
Attachment #363235 -
Flags: review?(mkanat)
|
|
Assignee | |
Comment 4•16 years ago
|
||
The initial implementation in bug 455641 regressed this.
Depends on: 455641
|
|
Assignee | |
Comment 5•16 years ago
|
||
Hum, we have to make sure what the caller wants.
Attachment #363235 -
Attachment is obsolete: true
Attachment #363236 -
Flags: review?(mkanat)
Attachment #363235 -
Flags: review?(mkanat)
|
||
Comment 6•16 years ago
|
||
Comment on attachment 363236 [details] [diff] [review]
patch, v1.1
Looks right to me.
Attachment #363236 -
Flags: review?(mkanat) → review+
|
|
||
Updated•16 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 7•16 years ago
|
||
Checking in Bugzilla/Field/Choice.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field/Choice.pm,v <-- Choice.pm
new revision: 1.9; previous revision: 1.8
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•