Closed
Bug 479588
Opened 16 years ago
Closed 16 years ago
Error console's text box should always be LTR
Categories
(Toolkit Graveyard :: Error Console, defect)
Toolkit Graveyard
Error Console
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: fixed1.9.1, rtl)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
dao
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Error console's text box should always be LTR, even for RTL elements, because the code entered into it is LTR. We should probably add the uri-element class to it. Patch forthcoming.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #363471 -
Flags: review?(dao)
|
||
Updated•16 years ago
|
Attachment #363471 -
Flags: review?(dao) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 363471 [details] [diff] [review]
Patch (v1)
That line should wrap. While you're at it, you could add a semicolon in onkeypress and remove value="".
|
|
||
Comment 3•16 years ago
|
||
Personally I'd rather make it LTR in components/console/content/console.css. uri-element isn't quite right, although I don't foresee that this could cause any trouble.
|
|
Assignee | |
Comment 4•16 years ago
|
||
Attachment #363471 -
Attachment is obsolete: true
Attachment #366197 -
Flags: review?(dao)
|
|
||
Updated•16 years ago
|
Attachment #366197 -
Flags: review?(dao) → review-
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 366197 [details] [diff] [review]
Patch (v2)
I think you want #TextboxEval, and there's probably no need for !important.
|
|
Assignee | |
Comment 6•16 years ago
|
||
Yes, you're right.
Attachment #366197 -
Attachment is obsolete: true
Attachment #366200 -
Flags: review?(dao)
|
|
||
Updated•16 years ago
|
Attachment #366200 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Comment 8•16 years ago
|
||
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)
Small theme-only change useful for RTL locales.
Attachment #366200 -
Flags: approval1.9.1?
|
||
Comment 9•16 years ago
|
||
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)
a191=beltzner
Attachment #366200 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 10•16 years ago
|
||
Keywords: fixed1.9.1
|
|
Assignee | |
Updated•16 years ago
|
Blocks: intl.css-cleanup
|
||
Updated•16 years ago
|
No longer blocks: intl.css-cleanup
|
|
||
Updated•16 years ago
|
Blocks: intl.css-cleanup
|
||
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•