Werner Henze Reporter
	Description • 16 years ago

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 1.1.4322; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2009022317 Firefox/3.0.1

Calls to NPN_SetValue with unsupported variables like NPPVpluginWindowSize (BTW, why is NPPVpluginWindowSize not supported? :-() return NPERR_NO_ERROR whereas I would expect them to return an error code. With the current implementation it is not possible to distinguish between a set operation succeeding or not being supported.

Reproducible: Always

Actual Results:  
Returns NPERR_NO_ERROR.

Expected Results:  
Return an error code.

See ns4xPlugin.cpp, function "NPError NP_CALLBACK _setvalue(NPP npp, NPPVariable variable, void *result)" -> switch -> default -> "return NPERR_NO_ERROR;".

	Josh Aas Assignee
	Comment 2 • 16 years ago

Nice catch, for the record WebKit returns a generic error for unsupported variables.

	Josh Aas Assignee
	Comment 3 • 16 years ago

pushed to trunk

http://hg.mozilla.org/mozilla-central/rev/a95010e34e4a

	Josh Aas Assignee
	Comment 4 • 16 years ago

Comment on attachment 367683 [details] [diff] [review]
fix v1.0

We should include this patch on the 1.9.1 branch, simple NPAPI compat fix.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 5 • 16 years ago

Comment on attachment 367683 [details] [diff] [review]
fix v1.0

a191=beltzner

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 6 • 16 years ago

Could you also add a test before landing  now that we have a test framework for plugins?

	Josh Aas Assignee
	Comment 8 • 16 years ago

test pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/9354d5829b88

	Josh Aas Assignee
	Comment 9 • 16 years ago

fix pushed to mozilla-1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bb25cb889bcb

	(not currently active) Ted Mielczarek
	Comment 10 • 15 years ago

Did you land the test on 1.9.1 as well?

	Josh Aas Assignee
	Comment 11 • 15 years ago

(In reply to comment #10)
> Did you land the test on 1.9.1 as well?

No.