Closed Bug 480079 Opened 16 years ago Closed 16 years ago

Move comm-central 7zSD.sfxes out of mozilla-central

Categories

(MailNews Core :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: robert.strong.bugs)

Details

Attachments

(2 files)

It looks like the CVS import for mozilla-central just swept up all of other-licenses/7zstub/, including seamonkey/, sunbird/, and thunderbird/. Having the 7zSD.sfx in a different repo than the app.tag makes nthomas ranty while doing hacks like attachment 364027 [details] [diff] [review] to make signing work, and we always want to save our "make him ranty" for times when we really need it, so if it's as easy as I naively think, just changing what we set SFX_MODULE to, we should.
Attached patch patch rev1 (deleted) — Splinter Review
Here is the comm-central patch... I verified this works with both Thunderbird and SeaMonkey
Assignee: nobody → robert.bugzilla
Attachment #364031 - Flags: review?(philringnalda)
Attachment #364031 - Flags: review?(bugzilla)
Attachment #364031 - Flags: review?(ctalbert)
Attached patch mozilla-central patch rev1 (deleted) — Splinter Review
Attachment #364032 - Flags: review?(philringnalda)
Attachment #364032 - Flags: review?(bugzilla)
Attachment #364032 - Flags: review?(ctalbert)
Comment on attachment 364031 [details] [diff] [review] patch rev1 Sweet.
Attachment #364031 - Flags: review?(philringnalda) → review+
Attachment #364032 - Flags: review?(philringnalda) → review+
I also verified this works with Sunbird
Attachment #364032 - Flags: review?(mschroeder)
Comment on attachment 364032 [details] [diff] [review] mozilla-central patch rev1 Martin, could you review these two patches for Sunbird? Thanks
Attachment #364031 - Flags: review?(mschroeder)
Attachment #364032 - Flags: review?(bugzilla) → review+
Attachment #364031 - Flags: review?(bugzilla) → review+
Attachment #364031 - Flags: review?(mschroeder)
Attachment #364031 - Flags: review?(ctalbert)
Attachment #364031 - Flags: review+
Comment on attachment 364031 [details] [diff] [review] patch rev1 r=mschroeder
Attachment #364032 - Flags: review?(mschroeder)
Attachment #364032 - Flags: review?(ctalbert)
Attachment #364032 - Flags: review+
Comment on attachment 364032 [details] [diff] [review] mozilla-central patch rev1 r=mschroeder
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: