Closed
Bug 480318
Opened 16 years ago
Closed 16 years ago
[FIX]"Save Page As" doesn't give the filename of the bugzilla attachment
Categories
(Firefox :: File Handling, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
When using Save Page As with bugzilla attachments, the default filename is attachment.cgi, not the real file name.
|
Assignee | |
Comment 1•16 years ago
|
||
This is totally my fault. Gotta love try/catch.
Assignee: nobody → bzbarsky
Blocks: 84106
Summary: "Save Page As" doesn't give the filename of the bugzilla attachment → [FIX]"Save Page As" doesn't give the filename of the bugzilla attachment
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #364318 -
Flags: review?(gavin.sharp)
|
||
Updated•16 years ago
|
Attachment #364318 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 364318 [details] [diff] [review]
I wish we had tests for this
:(
|
||
Comment 4•16 years ago
|
||
Is there actually more than one expected error, so the catch block can't just check for that and rethrow any other errors?
|
|
Assignee | |
Comment 5•16 years ago
|
||
Dunno. Looking at nsDOMWindowUtils::GetDocumentMetadata I wouldn't expect this code to ever get an exception to start with, so I have no idea why someone stuck a try/catch here.
|
|
||
Comment 6•16 years ago
|
||
Looks to me like we'll have to ask you either way: bug 263697 first, then bug 264757.
|
|
Assignee | |
Comment 7•16 years ago
|
||
Ah, that first checkin had the try/catch because the "get to window utils" part could throw.
|
|
Assignee | |
Comment 8•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•