Pan such that the navbar is showing, then zoomin(F7), the rightmost part of the canvas does not get painted. I think it's because vieportVisibleRect isn't reacting to partially hidden navbar correctly. Panning fixes things.

Oops, didn't realize you'd already filed this.

Er, wait, I'm confused. How is this different than bug 480639?

Nevermind, I can reproduce this now.

viewportInnerBounds is not updated after a zoom and that's the cause of the drawing error. It's good on dlbClick cause the click finish by calling endKinetic who do a ws.dragStop which is the only function calling _viewportUpdate. I'm not sure if it makes sense to had a startZooming/stopZooming code to WS? I force here a ws.dragStart/ws.dragStop but it's seems a little dirty since we are not in a dragging session. Futhermore this zooming code (F7/8 or ScrollWheel only) can lead to have partially opened sidebar which is bad (bug 470989, I need to refactor it to take that into account)

(In reply to comment #4) > Created an attachment (id=384084) [details] > dirty patch to show where the problem is > > viewportInnerBounds is not updated after a zoom and that's the cause of the > drawing error. > It's good on dlbClick cause the click finish by calling endKinetic who do a > ws.dragStop which is the only function calling _viewportUpdate. Maybe we should just call the function directly > I'm not sure if it makes sense to had a startZooming/stopZooming code to WS? Probably not > I force here a ws.dragStart/ws.dragStop but it's seems a little dirty since we > are not in a dragging session. Futhermore this zooming code (F7/8 or > ScrollWheel only) can lead to have partially opened sidebar which is bad (bug > 470989, I need to refactor it to take that into account) WidgetStack.panBy kind of does the same thing, checking to make sure we are not already dragging.

I _think_ this is more what we want - make sure to call _viewportUpdate from setViewportSize (which also handles calling _callViewportUpdateHandler).

Comment on attachment 384158 [details] [diff] [review] WIP r+, but remove the parts from other patches

Comment on attachment 384164 [details] [diff] [review] patch Merci! :)

verified FIXED on builds: Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821 Fennec/1.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre) Gecko/20090808 Fennec/1.0b3pre