Closed
Bug 480686
Opened 16 years ago
Closed 13 years ago
"ABORT: comparing iterators over different lists" with -moz-column, rtl, background image
Categories
(Core :: Layout, defect, P2)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files, 1 obsolete file)
###!!! ABORT: comparing iterators over different lists: 'mListLink == aOther.mListLink', file /Users/jruderman/central/layout/base/../generic/nsLineBox.h, line 684
Reporter | ||
Comment 1•16 years ago
|
||
Reporter | ||
Comment 2•16 years ago
|
||
Still happens on mozilla-central.
Reporter | ||
Comment 3•14 years ago
|
||
Still aborts debug builds. Seems harmless on opt.
Comment 4•14 years ago
|
||
I've seen this on whatwg for linux/mac at http://www.whatwg.org/specs/web-apps/current-work/
It is not reliable on this particular url, but spidering the anchors will almost always reproduce it.
http://www.whatwg.org/specs/web-apps/current-work/#attr-time-datetime
http://www.whatwg.org/specs/web-apps/current-work/#meta
http://www.whatwg.org/specs/web-apps/current-work/#the-canvas
The page appears to contain each of the elements of Jesse's test case.
The data from crash-stats for this url in April shows the related signatures: (counts are for the last week)
nsBulletFrame::GetListItemText 207 crashes (all Windows)
nsTextFrame::EnsureTextRun 107 crashes (most Windows, some Mac, Linux)
CompositeDataSourceImpl::cycleCollection::UnmarkPurple 3094 crashes (all Windows)
Assignee | ||
Comment 5•14 years ago
|
||
So what happens here is that nsCSSRendering::PaintBackgroundWithSC calls PrepareBackgroundLayer which calls InlineBackgroundData::GetContinuousRect, which calls IsOnSameLine for two frames that are in different columns, which fails the assertion.
Ideally we'd just check whether the two frames are in the same block, but that could be somewhat expensive.... I suppose we could check that just when the frames have different parents or something.
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #541901 -
Flags: review?(roc)
Assignee | ||
Comment 7•14 years ago
|
||
Attachment #541902 -
Flags: review?(roc)
Assignee | ||
Updated•14 years ago
|
Attachment #541901 -
Attachment is obsolete: true
Attachment #541901 -
Flags: review?(roc)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P2
Whiteboard: [need review]
Comment on attachment 541902 [details] [diff] [review]
With a comment typo fixed
Review of attachment 541902 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #541902 -
Flags: review?(roc) → review+
Assignee | ||
Comment 9•14 years ago
|
||
Whiteboard: [need review]
Target Milestone: --- → mozilla7
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite+
Comment 10•14 years ago
|
||
Interesting effect on m-i. The crashtest.list was
asserts(6) load 479360-1.xhtml # Bug 439258
load 481806-1.html
asserts(6) load 483604-1.xhtml # Bug 439258
and when you inserted another one in between, 483604-1.xhtml stopped getting its expected 6 assertion failures, and 481806-1.html got 6 unexpected ones. Apparently that annotation on 479360-1.xhtml needs to be "asserts(6), forces-asserts-on-not-the-next-but-the-one-after-that(6)".
Comment 11•13 years ago
|
||
(In reply to comment #9)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/bba3ada5314c
Backed out due to perma-orange on the new test:
http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=cfa057a48b48
Updated•13 years ago
|
Attachment #541902 -
Flags: checkin-
Updated•13 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: mozilla7 → ---
Comment 12•13 years ago
|
||
s/perma-orange on the new test/perma-orange because a previous test, the harness, and|or editor is broken/
Assignee | ||
Comment 13•13 years ago
|
||
> Apparently that annotation on 479360-1.xhtml needs to be
I made that into a comment and rejiggered the annotations. Then pushed this again as http://hg.mozilla.org/integration/mozilla-inbound/rev/062b3f071f81
Assignee | ||
Updated•13 years ago
|
Attachment #541902 -
Flags: checkin-
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → mozilla7
Comment 14•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•