Closed Bug 481198 Opened 16 years ago Closed 16 years ago

need to be able to clear msgWindow on a url

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b3

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

Attachments

(1 file, 2 obsolete files)

proposed fix
(deleted), patch
standard8
: review+
standard8
: superreview+
Details | Diff | Splinter Review
Attached patch proposed fix (obsolete) (deleted) — — Splinter Review
nsMsgMailNewsUrl::SetMsgWindow doesn't do anything if the passed in msg window is null. For the auto config code, I need the ability to clear the msg window on a url. Patch upcoming.
Flags: blocking-thunderbird3+
Attachment #365201 - Flags: superreview?(bugzilla)
Attachment #365201 - Flags: review?(bugzilla)
Comment on attachment 365201 [details] [diff] [review] proposed fix do_GetWeakReference seems to cope with null values: http://mxr.mozilla.org/comm-central/source/mozilla/xpcom/glue/nsWeakReference.cpp#100 can't we just drop the if?
Attached patch fix addressing comment (obsolete) (deleted) — — Splinter Review
right you are...
Attachment #365201 - Attachment is obsolete: true
Attachment #365449 - Flags: superreview?(bugzilla)
Attachment #365449 - Flags: review?(bugzilla)
Attachment #365201 - Flags: superreview?(bugzilla)
Attachment #365201 - Flags: review?(bugzilla)
Attachment #365449 - Flags: superreview?(bugzilla)
Attachment #365449 - Flags: superreview+
Attachment #365449 - Flags: review?(bugzilla)
Attachment #365449 - Flags: review+
fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Blocks: 481590
This regressed the MailNews Header-View, see Bug 481590. Sorry, but I don't know if this blocks or depends on the regression Bug, please correct this if I have set the wrong dependency.
I knew I was a bit cautious about this. TB and SM both showed the not marking newsgroup message as read issue, only SM showed the not displaying newsgroup headers properly issue. I've backed it out for now whilst we look at this. The marking read issue seems to be that we set the message window to a value, then later in the protocol setup, it gets stamped over by setting it to null, because it doesn't have the message window at that stage.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Well, it sounds like if it has a null msg window, it shouldn't set it...
Attached patch proposed fix (deleted) — — Splinter Review
I'll run with the assertion for a while and see if I hit it unexpectedly - so far, I haven't seen it.
Attachment #365449 - Attachment is obsolete: true
Attachment #365675 - Flags: superreview?(bugzilla)
Attachment #365675 - Flags: review?(bugzilla)
Attachment #365675 - Flags: superreview?(bugzilla)
Attachment #365675 - Flags: superreview+
Attachment #365675 - Flags: review?(bugzilla)
Attachment #365675 - Flags: review+
fix checked in with assertion still turned on for me - I'll remove it at some point...
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: