Closed
Bug 481374
Opened 16 years ago
Closed 15 years ago
Simplify / automate the addition of the pre-release suffix string (e.g. Alpha 1, Beta 2, etc.) - Port bug 468197 to TB
Categories
(Thunderbird :: Build Config, defect, P2)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: standard8, Assigned: gozer)
References
Details
Attachments
(1 file, 6 obsolete files)
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Firefox did some changes to their build config in bug 468197 to simplify release changes, it also simplifies some of the logic that's happening in the background as well.
As Thunderbird does pretty much the same things, I think we should port their code. Doesn't block TB 3 as what we have will work at the moment, but wanted because it will help our processes (and less to worry about missing).
gozer - fancy taking a shot at this sometime?
Flags: wanted-thunderbird3+
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → gozer
Assignee | ||
Updated•15 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•15 years ago
|
||
Turns out the Make/sed approach was dropped in favor of Python in bug 481703. I'll be porting *that* over shortly.
Assignee | ||
Comment 2•15 years ago
|
||
I've ported over the logic, and I can build it just fine. Somehow, however, I can't quite get the title to ever reflect the version.
(Note, this patch includes modified version.txt version-191.txt so it's testable)
Assignee | ||
Comment 3•15 years ago
|
||
This patch actually works correctly now. Running a beta/alpha versionned build correctly adds the right label to the window title.
The only thing left, is bug 502389, so for this patch, I've just disabled the setting of window.title in mail/base/content/tabmail.xml.
Attachment #386745 -
Attachment is obsolete: true
Assignee | ||
Comment 4•15 years ago
|
||
v2 was missing a little bit of autoconf/make foo, fixed.
Attachment #386923 -
Attachment is obsolete: true
Assignee | ||
Comment 5•15 years ago
|
||
Hrm, now that bug 502389 is closed, this works without touching tabmail.xml, but something is off. On linux, the title I get is:
- 3.0 Beta 3Shredder
Assignee | ||
Comment 6•15 years ago
|
||
With this patch, I believe the porting over is complete. Needs testing on Win32, as I haven't tested that flavor yet. Otherwise, should be complete.
Attachment #386926 -
Attachment is obsolete: true
Assignee | ||
Comment 7•15 years ago
|
||
This new patch should now be complete, including Windows installer files.
Not tested on Windows yet, however.
Attachment #387108 -
Attachment is obsolete: true
Attachment #387698 -
Flags: review?(bugzilla)
Reporter | ||
Comment 8•15 years ago
|
||
Minor change - a change (MOZ_APP_VERSION -> APP_VERSION) and a few removals had been missed from the port and were messing up the installer.
My local build passed, but I've just thrown the updated patch at the try server anyway to double check.
Attachment #387698 -
Attachment is obsolete: true
Attachment #387698 -
Flags: review?(bugzilla)
Reporter | ||
Comment 9•15 years ago
|
||
Minor correction to the v5a - remove the version change I didn't mean to include.
Otherwise this now works great, r=Standard8
Attachment #387851 -
Attachment is obsolete: true
Attachment #387903 -
Flags: review+
Reporter | ||
Comment 10•15 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/5037fd3fea18
Just thinking it may be a good idea to have a litmus test or some other QA check that the "xxx alpha/beta n" string is in place on Windows & Linux when we do alpha & beta releases and not others (also on window we change the installation directory).
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Flags: in-litmus?
Resolution: --- → FIXED
Comment 11•15 years ago
|
||
(In reply to comment #10)
> Checked in: http://hg.mozilla.org/comm-central/rev/5037fd3fea18
>
> Just thinking it may be a good idea to have a litmus test or some other QA
> check that the "xxx alpha/beta n" string is in place on Windows & Linux when we
> do alpha & beta releases and not others (also on window we change the
> installation directory).
I think this belongs to a check list. There is no way to distinguish what you are testing in Litmus (alpha, release, etc ....)
Flags: in-litmus? → in-litmus-
Reporter | ||
Comment 12•15 years ago
|
||
(In reply to comment #11)
> I think this belongs to a check list. There is no way to distinguish what you
> are testing in Litmus (alpha, release, etc ....)
Ok, I've added it to: https://wiki.mozilla.org/Releases/Thunderbird_3.0b4#QA_of_Builds
You need to log in
before you can comment on or make changes to this bug.
Description
•