Closed
Bug 482051
Opened 16 years ago
Closed 10 years ago
xpcshell unit tests do not need to set browser.privatebrowsing.keep_current_session
Categories
(Firefox :: Private Browsing, defect, P3)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Depends on 1 open bug, )
Details
Attachments
(1 file)
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
When bug 462832 lands, xpcshell unit tests no longer need to set the browser.privatebrowsing.keep_current_session pref, because the nsIPrivateBrowsingSession implementation which actually uses that pref does not exist in that environment. This bug will remove the responsible code for setting this pref from those tests.
Updated•16 years ago
|
Priority: -- → P3
Target Milestone: --- → Firefox 3.2a1
Updated•10 years ago
|
Target Milestone: Firefox 3.6a1 → ---
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8587533 -
Flags: review?(josh)
Updated•10 years ago
|
Attachment #8587533 -
Flags: review?(josh) → review+
Backed out for bc1 orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/f76ade6c3db1
https://treeherder.mozilla.org/logviewer.html#?job_id=8437228&repo=mozilla-inbound
Flags: needinfo?(ehsan)
Comment 3•10 years ago
|
||
Sorry, I missed the "," instead of ";" in browser_354894_perwindowpb.js.
Assignee | ||
Comment 4•10 years ago
|
||
Flags: needinfo?(ehsan)
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in
before you can comment on or make changes to this bug.
Description
•