We already implement getBrowserForDocument() so as a follow up we should also implement the related methods getBrowserAtIndex() and getBrowserIndexForDocument(). Google code search shows: 101 hits for getBrowserForDocument: http://www.google.com/codesearch?as_q=getBrowserForDocument&btnG=Search+Code&hl=en&as_lang=javascrip&as_case=y 148 hits for getBrowserAtIndex: http://www.google.com/codesearch?as_q=getBrowserAtIndex&btnG=Search+Code&hl=en&as_lang=javascrip&as_case=y 46 hits for getBrowserIndexForDocument: http://www.google.com/codesearch?as_q=getBrowserIndexForDocument&btnG=Search+Code&hl=en&as_lang=javascrip&as_case=y A wider search shows: 12,000,000 for getBrowserForDocument: (???) http://www.google.com/search?&q=getBrowserForDocument&btnG=Search 834 for getBrowserAtIndex: http://www.google.com/search?&q=getBrowserAtIndex&btnG=Search 12,300 for getBrowserIndexForDocument: http://www.google.com/search?&q=getBrowserIndexForDocument&btnG=Search

1. Implement |getBrowserForDocumentInternal| and make both |getBrowserForDocument| and |getBrowserIndexForDocument| use this. 2. Implement |getBrowserAtIndex|

Comment on attachment 366352 [details] [diff] [review] Patch v1.0 IMHO that's overkill. If you don't want to duplicate the for loop just implement getBrowserForDocument in terms of the other two.

Minimal really simple brain dead patch.

Comment on attachment 366491 [details] [diff] [review] [For checkin] Patch v2.0 I see you managed to avoid copying the tab ;-)

Oops: http://hg.mozilla.org/comm-central/rev/653c11aa0e13