Closed
Bug 482394
Opened 16 years ago
Closed 16 years ago
[FIX]aForStyling check in IsHTMLLink/IsLink causes bogus behavior
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
roc
:
approval1.9.1+
|
Details | Diff | Splinter Review |
I ran into this while trying to write a test for bug 481335. The problem is that we hit IsHTMLLink from HasAttributeDependentStyle() after changing the href. The At this point, aForStyling is false, so we do not add the node to the document's style-relevant links (from which its SetAttr function removed it). But then when we do the "real" style resolution we don't add it either, since at that point the link state is not unknown.
We probably just need to add the anchor any time we set its link state from unknown to something else here. :(
|
Assignee | |
Comment 1•16 years ago
|
||
Oh, this regressed with bug 416317. Not sure whether we want to fix this on 1.9.1 at this point... I'm tempted to say we do.
Blocks: querySelector
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #366494 -
Flags: superreview?(dbaron)
Attachment #366494 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•16 years ago
|
Summary: aForStyling check in IsHTMLLink/IsLink causes bogus behavior → [FIX]aForStyling check in IsHTMLLink/IsLink causes bogus behavior
|
||
Comment 3•16 years ago
|
||
Comment on attachment 366494 [details] [diff] [review]
Fix
r+sr=dbaron, and it seems worth getting on 1.9.1
(Also, whoever wrote those tests should learn about todo_is and todo_isnot.)
Attachment #366494 -
Flags: superreview?(dbaron)
Attachment #366494 -
Flags: superreview+
Attachment #366494 -
Flags: review?(dbaron)
Attachment #366494 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Per comment 0, I wrote the test. ;) And those weren't around at some point, I tell you!
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 366494 [details] [diff] [review]
Fix
Pretty safe fix, fixes regression from 1.9.0.
Attachment #366494 -
Flags: approval1.9.1?
|
|
Assignee | |
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: wanted1.9.1?
Flags: in-testsuite+
Resolution: --- → FIXED
Attachment #366494 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 7•16 years ago
|
||
Flags: wanted1.9.1?
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•