Closed
Bug 482720
Opened 16 years ago
Closed 16 years ago
make use of the firefox throbber
Categories
(Thunderbird :: Toolbars and Tabs, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: andreasn, Assigned: clarkbw)
References
Details
(Whiteboard: [tango])
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.7) Gecko/2009030422 Ubuntu/8.10 (intrepid) Firefox/3.0.7 Ubiquity/0.1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4pre) Gecko/20090310 Shredder/3.0b3pre
The throbber from Firefox3 looks a lot nicer than the current one. I suggest changing to that instead.
Reproducible: Always
Reporter | ||
Updated•16 years ago
|
Whiteboard: Tango
Version: unspecified → Trunk
Reporter | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
updating the patch using hg and removing the other throbber gifs
Assignee: nobody → clarkbw
Attachment #366815 -
Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•16 years ago
|
||
Comment on attachment 366820 [details] [diff] [review]
[checked in] replace all throbber gifs w/ png from patch
This looks a lot better than the gif did.
Assuming this looks good I can do similar patches for windows and mac as well.
Attachment #366820 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•16 years ago
|
Severity: normal → enhancement
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0b3
Comment 4•16 years ago
|
||
Comment on attachment 366820 [details] [diff] [review]
[checked in] replace all throbber gifs w/ png from patch
Yeah this is nicer. r=mkmelin
Remember to remove the old png file later when it's not used anymore.
Attachment #366820 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 5•16 years ago
|
||
setting keyword for checkin of attachment 366820 [details] [diff] [review], keep this bug open until I've gotten the other themes fixed
Keywords: checkin-needed
Assignee | ||
Comment 6•16 years ago
|
||
the pinestripe theme already uses this spinner
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/messenger.css#70
I'll get the windows patch tomorrow with additional fixes to the gnomestripe theme to make sure it's not using the gif anymore.
http://mxr.mozilla.org/comm-central/search?find=%2Fmail%2Fthemes%2F&string=Throbber-small.gif
Comment 7•16 years ago
|
||
Comment on attachment 366820 [details] [diff] [review]
[checked in] replace all throbber gifs w/ png from patch
Checked in: http://hg.mozilla.org/comm-central/rev/be064d80219d
Attachment #366820 -
Attachment description: replace all throbber gifs w/ png from patch → [checked in] replace all throbber gifs w/ png from patch
Updated•16 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•16 years ago
|
||
(In reply to comment #4)
> Remember to remove the old png file later when it's not used anymore.
The Throbber files look like they are part of the toolkit themes, I'm not finding any other references to them inside mail.
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/winstripe/global/throbber/
I'll upload the second patch I have that removes the old throbber from win/lin mail.
Assignee | ||
Comment 9•16 years ago
|
||
here's the final cleanup of gnomestripe and the switch on windows as well
Attachment #368320 -
Flags: review?(mkmelin+mozilla)
Updated•16 years ago
|
Attachment #368320 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: Tango → [tango][wating for checkin]
Comment 10•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [tango][wating for checkin] → [tango]
You need to log in
before you can comment on or make changes to this bug.
Description
•