Closed
Bug 483635
Opened 16 years ago
Closed 16 years ago
Mochitest test_terminate.html runs fine but needs to check/report success
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])
Attachments
(1 file)
|
(deleted),
patch
|
bent.mozilla
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
(I noticed this on my Windows SeaMonkey/1.9.2 build...)
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237214422.1237222129.17732.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/16 07:40:22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237214422.1237217596.4967.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/16 07:40:22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237215397.1237221564.16368.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/16 07:56:37
*** 29527 INFO Running /tests/dom/src/threads/test/test_terminate.html...
*** 29529 INFO Running /tests/dom/src/threads/test/test_threadErrors.html...
}
|
Assignee | |
Comment 1•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090316 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/8d186b98ff31)
Also add an explicit |var| initial value.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #367619 -
Flags: review?(ctalbert.moz)
|
|
Assignee | |
Updated•16 years ago
|
Flags: in-testsuite+
Summary: Mochitest test_threadErrors.html runs fine but needs to check/report success → Mochitest test_terminate.html runs fine but needs to check/report success
|
|
Assignee | |
Updated•16 years ago
|
Attachment #367619 -
Flags: review?(ctalbert.moz) → review?(jonas)
Attachment #367619 -
Flags: superreview+
Attachment #367619 -
Flags: review?(jonas)
Attachment #367619 -
Flags: review?(bent.mozilla)
Comment on attachment 367619 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 4 & 6]
Bents test, so would like his input.
Comment on attachment 367619 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 4 & 6]
The interval change is unnecessary but harmless (default is 'undefined' which evaluates to false).
Attachment #367619 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 367619 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 4 & 6]
http://hg.mozilla.org/mozilla-central/rev/c049ba50ea04
Av1, with comment 3 suggestion(s).
(In reply to comment #3)
> (default is 'undefined' which evaluates to false).
Ah, indeed: undefined != false, but !undefined == true :->
Attachment #367619 -
Attachment description: (Av1) Add |ok(true, ...);| → (Av1) Add |ok(true, ...);|
[Checkin: See comment 4]
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Comment 5•16 years ago
|
||
V.Fixed
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237595933.1237599152.17944.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/20 17:38:53
*** 29567 INFO Running /tests/dom/src/threads/test/test_terminate.html...
*** 29568 INFO TEST-PASS | /tests/dom/src/threads/test/test_terminate.html | no more messages
}
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs 1.9.1 landing: after bug 466254]
|
|
Assignee | |
Comment 6•16 years ago
|
||
Comment on attachment 367619 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 4 & 6]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e38aa0775c8a
Attachment #367619 -
Attachment description: (Av1) Add |ok(true, ...);|
[Checkin: See comment 4] → (Av1) Add |ok(true, ...);|
[Checkin: See comment 4 & 6]
|
|
Assignee | |
Comment 7•16 years ago
|
||
(In reply to comment #6)
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e38aa0775c8a
(Bv1-191) Add |ok(true, ...);|
as bug 466254 won't land on 1.9.1 branch.
Depends on: 466254
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing: after bug 466254] → [fixed1.9.1b4]
|
|
Assignee | |
Updated•15 years ago
|
|
||
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
|
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•