Ben Turner (not reading bugmail, use the needinfo flag!) Reporter
	Description • 16 years ago

Quickstubs are being made traceable in bug 480187, but to do so we have to include jsbuiltins.h which draws in nanojit and avm internals. We have to include AVMPLUS and FEATURE_NANOJIT defines as well. We need to figure out a better way to allow friends to make traceable functions.

	Nicholas Nethercote [inactive]
	Comment 1 • 13 years ago

There's a similar problem with the headers for the method JIT.  I just tried #including methodjit/MethodJIT.h into xpcjsruntime.cpp and got problems because various things in js-confdefs.h are needed, including some or all of these (this is for an X64 build, they'll be a little different for x86 or ARM):

#define JS_METHODJIT 1
#define JS_MONOIC 1
#define JS_POLYIC 1
#define JS_POLYIC_TYPED_ARRAY 1
#define JS_PUNBOX64 1

I ended up finding a different solution whereby I didn't have to #include methodjit/MethodJIT.h, because pulling the relevant #defines out of js-confdefs.h felt too fragile -- the constants required by the method JIT don't have names as distinguished as the AVMPLUS ones.

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 2 • 13 years ago

The hack was removed in bug 698201.