Closed Bug 484122 Opened 16 years ago Closed 16 years ago

geolocation timeout due to string change

Categories

(Core :: DOM: Geolocation, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

Attached patch patch v.1 (deleted) — Splinter Review
when strings were change: http://hg.mozilla.org/mozilla-central/rev/c0eea14622a6 our mochitest failed: Unknown Error: command finished with exit code: 2 *** 41419 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/geolocation/test_allowCurrent.html | Clicked "Exact Location (within 10 feet)" button buildbot.slave.commands.TimeoutError: command timed out: 300 seconds without output, killing pid 30879 This is due to the test cases relying on the actual text of the string in the buttons of the notification info bar. This is pretty weak, but other mochitest do the same thing. This is a quick fix. we should actually not rely on the text of the buttons, but rather their id or something that doesn't change.
Attachment #368173 - Flags: review?(bent.mozilla)
Attachment #368173 - Flags: review?(bent.mozilla) → review+
What is the status here ?
this landed, and then we stop using strings to id the particular button.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: