User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.7) Gecko/2009030422 Ubuntu/8.10 (intrepid) Firefox/3.0.7 Ubiquity/0.1.5 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4pre) Gecko/20090318 Shredder/3.0b3pre Need to update the icon. Reproducible: Always

to go into mail/themes/gnomestripe/mail/icons/

updated junk icon. also changed mode from 755 to 644 because it's annoying to have images show up as executable. This piece is a little out of step as bug 483761 hasn't landed yet. We also need to get header column icons, see bug 483761 comment 8

Comment on attachment 370108 [details] [diff] [review] hg patch w/ updated junk icon I haven't tested this since I first dropped it in there but I can't imagine there would be conflicts on the icon. Most of the other junk icons have landed except for the toolbar so it'd be good to get this one in as well. Thanks!

Comment on attachment 370108 [details] [diff] [review] hg patch w/ updated junk icon r=mkmelin

Checked in: http://hg.mozilla.org/comm-central/rev/ca8e8499a972

"Crumpled paper" is a bad metaphor for "junk": it is hardly recognizable at any small size, and it is likely to confuse users. In real life, you crumple paper when it is not needed, when it contains mistakes, and you throw it away - usually in a trash can or paper recycling bin. Unsolicited mail is usually destroyed or recycled directly, without being opened or [re]used. In Thunderbird 2.x junk goes into a folder clearly labeled with fire - i.e. "to be destroyed". The new icon set breaks a common pattern currently visible in most software: crumpled paper appears in the trash icon when you delete items. In TB 3 deleted item are moved to the trash, implicitly becoming crumpled paper, but junk is also shown as crumpled paper, which ends up in the... "crumpled paper container". This has -no- real life counterpart, thus it is non-realistic metaphor which has no grounding in any common concept of visual pattern, and will lead users to confusion. A good metaphor should suggest that junk is headed for destruction and is -not- related to the trash, since junk is never moved to the trash folder.

Typo, might seriously change the meaning of the sentence: "in any common concept of visual pattern" should read "in any common concept or visual pattern".