Closed
Bug 484621
Opened 16 years ago
Closed 16 years ago
Port Bug 471962: When saving an inner frame as file only, the POST data of the outer page is sent to the address of the inner page
Categories
(SeaMonkey :: Download & File Handling, defect)
SeaMonkey
Download & File Handling
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0b1
People
(Reporter: Callek, Assigned: Callek)
References
(Blocks 1 open bug)
Details
(Keywords: fixed-seamonkey1.1.17, fixed1.8.1.22, Whiteboard: [sg:low])
Attachments
(3 files)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
dveditz
:
approval1.8.1.next+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bzbarsky
:
review+
dveditz
:
approval1.8.1.next+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #483959 +++
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug471962.js | The saved inner frame does not contain outer POST data
}
I'll fix 1.9.1 for SeaMonkey, and 1.8.1 for SeaMonkey, this may also affect 1.8.1 TB, doubt it is worth fixing there, but if someone identifies it as a problem I'll do so.
Flags: blocking-seamonkey2.0b1?
Flags: blocking-seamonkey1.1.16?
|
Assignee | |
Comment 2•16 years ago
|
||
This is a direct port of the patch in Bug 471962. Does make their test pass for us.
Attachment #368783 -
Flags: superreview?(neil)
Attachment #368783 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Attachment #368783 -
Flags: superreview?(neil)
Attachment #368783 -
Flags: superreview+
Attachment #368783 -
Flags: review?(neil)
Attachment #368783 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #368783 -
Attachment description: Patch for SeaMonkey c-c → Patch for SeaMonkey c-c [checked-in]
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•16 years ago
|
||
The SeaMonkey 1.1.x version of the above
Attachment #368807 -
Flags: superreview?(neil)
Attachment #368807 -
Flags: review?(neil)
|
|
Assignee | |
Comment 4•16 years ago
|
||
I doubt normal builds of TB need this, but for the benefit of XULRunner on 1.8.1 and linux distro's can't hurt to push the toolkit fix while I'm here. (r? on bz since he reviewed original patch).
Attachment #368809 -
Flags: review?(bzbarsky)
|
||
Updated•16 years ago
|
Component: Session Restore → Download & File Handling
QA Contact: session.restore → download
|
|
||
Updated•16 years ago
|
Attachment #368807 -
Flags: superreview?(neil)
Attachment #368807 -
Flags: superreview+
Attachment #368807 -
Flags: review?(neil)
Attachment #368807 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #368807 -
Flags: approval1.8.1.next?
|
||
Comment 5•16 years ago
|
||
V.Fixed, as SeaMonkey tinderboxes pass bug 483959 test now.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Target Milestone: --- → seamonkey2.0b1
|
||
Updated•16 years ago
|
Attachment #368809 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #368809 -
Flags: approval1.8.1.next?
|
||
Updated•16 years ago
|
Attachment #368807 -
Flags: approval1.8.1.next? → approval1.8.1.next+
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 368809 [details] [diff] [review]
Toolkit (Thunderbird) version, 1.8.1
Approved for 1.8.1.22, a=dveditz for release-drivers
Attachment #368809 -
Flags: approval1.8.1.next? → approval1.8.1.next+
|
|
||
Comment 7•16 years ago
|
||
I guess I didn't need to approve the seamonkey-only patch
|
|
Assignee | |
Comment 8•16 years ago
|
||
dveditz, can you please commit these two 1.8.x patches, just moved today and won't have net access where I can utilize my ssh key for a while.
Keywords: checkin-needed
|
|
||
Updated•16 years ago
|
Whiteboard: [sg:low] → [c-n: cvs/1.8.1] [sg:low]
|
||
Comment 9•16 years ago
|
||
Checking in toolkit/content/contentAreaUtils.js;
/cvsroot/mozilla/toolkit/content/contentAreaUtils.js,v <-- contentAreaUtils.js
new revision: 1.77.2.8; previous revision: 1.77.2.7
done
Checking in xpfe/communicator/resources/content/contentAreaUtils.js;
/cvsroot/mozilla/xpfe/communicator/resources/content/contentAreaUtils.js,v <--
contentAreaUtils.js
new revision: 1.134.2.7; previous revision: 1.134.2.6
done
Keywords: checkin-needed → fixed1.8.1.22
|
|
||
Updated•16 years ago
|
Flags: blocking-seamonkey2.0b1?
Flags: blocking-seamonkey1.1.16?
Whiteboard: [c-n: cvs/1.8.1] [sg:low] → [sg:low]
|
|
||
Updated•16 years ago
|
Group: core-security
|
|
||
Updated•16 years ago
|
Keywords: fixed-seamonkey1.1.17
You need to log in
before you can comment on or make changes to this bug.
Description
•