Closed
Bug 485187
Opened 16 years ago
Closed 16 years ago
Rename gDownloadLastDir.path to gDownloadLastDir.file and gDownloadLastDirPath to gDownloadLastDirFile
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
()
Details
(Keywords: dev-doc-complete, verified1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Follow-up from bug 464795 comment 17:
I missed this in the original review, but having a variable whose name includes
"path" (gDownloadLastDir.path/gDownloadLastDirPath) refer to an nsIFile instead
of an actual file path is fairly confusing.
Attachment #369285 -
Flags: review?(gavin.sharp)
|
||
Updated•16 years ago
|
Attachment #369285 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 369285 [details] [diff] [review]
Patch
This is a basic renaming patch, and poses very little risk. It would be great to have this on 1.9.1 for API consistency between that branch and trunk.
Attachment #369285 -
Flags: approval1.9.1?
|
||
Comment 3•16 years ago
|
||
Comment on attachment 369285 [details] [diff] [review]
Patch
a191=beltzner
Attachment #369285 -
Flags: approval1.9.1? → approval1.9.1+
|
||
Updated•16 years ago
|
Whiteboard: [checkin after bug 464795]
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•16 years ago
|
Whiteboard: [checkin after bug 464795] → [needs 191 landing after bug 464795]
|
||
Comment 5•16 years ago
|
||
Added appropriate notes to the https://developer.mozilla.org/En/Firefox_3.5_for_developers article.
Keywords: dev-doc-needed → dev-doc-complete
|
|
||
Comment 6•16 years ago
|
||
Please get this in right away.
|
|
||
Comment 7•16 years ago
|
||
This landed on 1.9.1 as part of bug 464795.
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing after bug 464795]
|
|
||
Comment 8•16 years ago
|
||
Verified fixed on trunk and 1.9.1 based on code check-in and green boxes.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•