Closed
Bug 485410
Opened 16 years ago
Closed 16 years ago
Build jemalloc on Windows better
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
jemalloc on Windows was failing to build with pymake because of backslash-escaping nonsense in sh. This fixes it by quoting each invocation. Also the shell forloop was eating errors, so I switched it to independent commands.
Attachment #369558 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 369558 [details] [diff] [review] jemalloc+pymake fixes, rev. 1 Did you intentionally reindent all those comments to the beginning of the line?
Attachment #369558 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
Yes: a command that begins with <tab># gets run as a shell command. A # at the beginning of the line is a makefile comment.
|
|
||
Comment 3•16 years ago
|
||
ah, ew. We probably have more of that strewn about the build system...
|
|
Assignee | |
Comment 4•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e4c426478d47
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•