Closed
Bug 485458
Opened 16 years ago
Closed 16 years ago
browser-chrome test for bookmarks Properties dialog
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Need a test for this dialog
Comment 1•16 years ago
|
||
Please see Bug 481690
"Undo" of the edit context menu is useless in the library and the Properties window.
Assignee | ||
Comment 2•16 years ago
|
||
that is a separate bug, won't take take of it here, purpose of this bug is only to create a test where we can add test cases in future.
Assignee | ||
Comment 3•16 years ago
|
||
Assignee | ||
Comment 4•16 years ago
|
||
This was an interesting task... While writing the test i've found a problem in the _initialized property of editItemOverlay, is fixed here, simply an assignment move.
Attachment #369685 -
Attachment is obsolete: true
Attachment #369811 -
Flags: review?(dietrich)
Assignee | ||
Comment 5•16 years ago
|
||
ops. the head_bookmarks.js change is unwanted, so please ignore that.
Assignee | ||
Comment 6•16 years ago
|
||
minor cleanup, removed non test changes (the editBookmarkOverlay change should land before this with bug 427633 chrome test.
Attachment #369811 -
Attachment is obsolete: true
Attachment #370442 -
Flags: review?(dietrich)
Attachment #369811 -
Flags: review?(dietrich)
Comment 7•16 years ago
|
||
Comment on attachment 370442 [details] [diff] [review]
patch v1.1
r=me. please add a list of the common actions for that dialog that are not yet tested (basic add/edit for all types and fields, microsummaries, feeds, etc), and file a followup bug for adding them.
Attachment #370442 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 8•16 years ago
|
||
filed Bug 486510 with a preliminary lists of actions to test.
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 9•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
Comment 10•16 years ago
|
||
This line in the test is wrong:
EventUtils.synthesizeKey("VK_ESC", {}, self.window);
It should be VK_ESCAPE not VK_ESC.
Assignee | ||
Comment 11•16 years ago
|
||
a small change to fix the wrong key constant
Assignee | ||
Comment 12•16 years ago
|
||
fixed key code
http://hg.mozilla.org/mozilla-central/rev/19672932377e
Assignee | ||
Comment 13•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1829526d16f0
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/297f4615ddfe
on 1.9.1 i disabled 3 tests that are about not yet approved patches.
Keywords: fixed1.9.1
Assignee | ||
Comment 14•16 years ago
|
||
i temporarly disabled the test on 1.9.1 due to some strange crashes, this will be tracked in bug 487040, adding as a dependancy, i don't think the test is directly involved in causing the crash, but helps making that more visible.
on m-c the test is active and testing all the patches, since there crashes happens really rarely.
Depends on: 487040
Comment 15•16 years ago
|
||
Seems like the tests work well on trunk and 1.9.1. Thanks Marco!
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Assignee | ||
Comment 16•16 years ago
|
||
it is disabled on 1.9.1 but working fine on trunk, see comment 14, clearly i want to re enable it on 1.9.1 asap.
Comment 17•16 years ago
|
||
Thanks. Resetting flag back to fixed1.9.1. Will recheck when the remaining tests are active.
Keywords: verified1.9.1 → fixed1.9.1
Comment 18•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•