2 possibilities: 1- trivial Force it at http://hg.mozilla.org/mozilla-central/annotate/67b29b1eea64/config/rules.mk#l146 2- more complicated Support an extra argument and set it from http://mxr.mozilla.org/build/source/buildbotcustom/unittest/steps.py Ted, do you agree for 1- ?

Actually I was thinking of just removing this option and making it the default behavior. I added it for testing, but I think it'd be a better default, especially for tinderbox.

(In reply to comment #1) > I added it for testing, but I think it'd be a better default, I concur! :-)

Comment on attachment 369825 [details] [diff] [review] (Av1) Drop option, make it the new behavior [Checkin: Comment 7 & 8] Note this patch is the option removal only: it allows to proceed the current |runxpcshelltests.py| call to its end, but no more. ***** To get the full |make| run, we would need to either |sys.exit(0)| from |runxpcshelltests.py| or somehow have |make| not stop on the non-zero return code. I'm happy with neither, but what do you think ? Is it something the new |manifest| option will allow to solve in a better way (= non-recursive calls) ??

I think I'd like to change how the tests are invoked. Maybe add another target like "make xpcshell-tests" which just runs the tests using the manifest, and stop invoking them from check. We can do that in another bug though, this patch will be a nice improvement on the current behavior.

(In reply to comment #4) > We can do that in another bug though I filed bug 485736.

Comment on attachment 369825 [details] [diff] [review] (Av1) Drop option, make it the new behavior [Checkin: Comment 7 & 8] Looks good, thanks!

Comment on attachment 369825 [details] [diff] [review] (Av1) Drop option, make it the new behavior [Checkin: Comment 7 & 8] http://hg.mozilla.org/mozilla-central/rev/dc728e996a0d

Comment on attachment 369825 [details] [diff] [review] (Av1) Drop option, make it the new behavior [Checkin: Comment 7 & 8] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f241563df68f