Closed
Bug 485728
Opened 16 years ago
Closed 16 years ago
TUnit test_intl_locale tests get executed twice now
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
(Keywords: fixed1.9.1, regression, Whiteboard: [fixed1.9.1b4, in bug 360018])
Attachments
(1 file)
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
This happens on MacOSX and Windows, but not Linux;
it's trunk only;
I reproduce it on my local SeaMonkey/1.9.2.
Regression timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-03-18+01%3A22%3A50&enddate=2009-03-18+01%3A47%3A29
caused by
http://hg.mozilla.org/mozilla-central/rev/81dc4af9e961
This directory is executed both from 'intl/locale/tests' and 'intl/locale/tests_multilocale'.
Before:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237364751.1237377089.15377.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:25:51
make[3]: Entering directory `/e/builds/moz2_slave/mozilla-central-win32-unittest/build/objdir/intl/locale/tests'
d:/mozilla-build/python25/python.exe -u \
/e/builds/moz2_slave/mozilla-central-win32-unittest/build/testing/xpcshell/runxpcshelltests.py \
../../../dist/bin/xpcshell \
/e/builds/moz2_slave/mozilla-central-win32-unittest/build \
../../../_tests/xpcshell/test_intl_locale/unit
}
After:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366264.1237378437.22583.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:51:04
make[3]: Entering directory `/e/builds/moz2_slave/mozilla-central-win32-unittest/build/objdir/intl/locale/tests'
d:/mozilla-build/python25/python.exe -u \
/e/builds/moz2_slave/mozilla-central-win32-unittest/build/testing/xpcshell/runxpcshelltests.py \
../../../dist/bin/xpcshell \
/e/builds/moz2_slave/mozilla-central-win32-unittest/build \
../../../_tests/xpcshell/test_intl_locale/unit
...
make[3]: Entering directory `/e/builds/moz2_slave/mozilla-central-win32-unittest/build/objdir/intl/locale/tests_multilocale'
d:/mozilla-build/python25/python.exe -u \
/e/builds/moz2_slave/mozilla-central-win32-unittest/build/testing/xpcshell/runxpcshelltests.py \
../../../dist/bin/xpcshell \
/e/builds/moz2_slave/mozilla-central-win32-unittest/build \
../../../_tests/xpcshell/test_intl_locale/unit
}
Flags: wanted1.9.2?
Flags: in-testsuite-
Assignee | ||
Comment 1•16 years ago
|
||
Untested, but trivial.
Assignee: smontagu → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #372893 -
Flags: review?(smontagu)
Assignee | ||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> (Av1) Fix MODULE name
This is the easiest fix,
though renaming the directory from 'tests_multilocale/unit' to 'tests/multilocale' may be better. Not sure.
Target Milestone: --- → mozilla1.9.2a1
Updated•16 years ago
|
Attachment #372893 -
Flags: review?(smontagu) → review+
Comment 3•16 years ago
|
||
(In reply to comment #2)
> This is the easiest fix,
> though renaming the directory from 'tests_multilocale/unit' to
> 'tests/multilocale' may be better. Not sure.
I think I prefer it this way.
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 372893 [details] [diff] [review]
(Av1) Fix MODULE name
[Checkin: Comment 4]
http://hg.mozilla.org/mozilla-central/rev/32dc8d681ecf
1.9.1 landing already included in bug360018 comment 59.
Attachment #372893 -
Attachment description: (Av1) Fix MODULE name → (Av1) Fix MODULE name
[Checkin: Comment 4]
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: wanted1.9.2?
Keywords: fixed1.9.1
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed1.9.1b4, in bug 360018]
Assignee | ||
Comment 5•16 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239884280.1239887836.14926.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/04/16 05:18:00
V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•