Closed Bug 486395 Opened 16 years ago Closed 16 years ago

Unable to copy url from location bar in popup

Categories

(Firefox :: Theme, defect)

3.0 Branch
All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: bzbarsky, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: verified1.9.1)

Attachments

(2 files)

STEPS TO REPRODUCE: 1) Load attached HTML file 2) Click the link 3) Select the url in the url bar with the mouse. 4) Cmd-C to copy it. EXPECTED RESULTS: URL copied ACTUAL RESULTS: Clipboard not affected. This makes life suck a lot on sites that pop up the "printable" version of articles in a window like that; if I want to send the url to someone else, I have to jump through hoops. ADDITIONAL INFORMATION: 1) This is worksforme on Linux, but I can reproduce quite reliably on Mac. 2) I did some debugging, and it looks like browser.css sets "-moz-user-input: disable" on the urlbar in this case (due to the readonly attribute). This means that all event handling on the input is suppressed, because of the code in nsHTMLInputElement::PreHandleEvent. In particular, the keypress event is just not dispatched at all, hence not seen by the XBL key event handler, and we get nowhere close to triggering the code in urlbarBindings.xml. I would expect this to be the case on all platforms, though, so not sure why this works on Linux. 3) Using the menu's Edit > Copy to copy the text works fine. 4) For some reason there is no context menu for the url bar in this case. I can file that as a separate bug, if it's caused by something other than the user-input styles above. This looks like a regression from bug 419772.
My obvious suggested fix is to remove that user-input style, fwiw.
Attached file Testcase (deleted) —
WFM in windows too
I can't think of a good reason to have that style, so removing it sounds good to me. Odd that it behaves differently on Linux and Windows, though...
Component: Location Bar and Autocomplete → Theme
QA Contact: location.bar → theme
For what it's worth, this is the most annoying thing for me about daily Firefox use at this point... I hit it all the time on sites that pop up windows for their "printer friendly" article versions.
Flags: blocking-firefox3.6?
Blocks: 489689
Assignee: nobody → dao
(In reply to comment #4) > Odd that it behaves differently on Linux and Windows, though... That's because only pinstripe sets -moz-user-input: disabled; for #urlbar[readonly="true"].
Attached patch patch (deleted) — Splinter Review
Attachment #374427 - Flags: review?(gavin.sharp)
Attachment #374427 - Flags: review?(gavin.sharp) → review+
Comment on attachment 374427 [details] [diff] [review] patch Oh, I didn't look closely enough and just saw the three hits across the three themes.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Version: unspecified → 3.0 Branch
Attachment #374427 - Flags: approval1.9.1?
Verified on trunk with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090426 Minefield/3.6a1pre ID:20090426031353
Status: RESOLVED → VERIFIED
Flags: blocking-firefox3.6?
Hardware: x86 → All
Flags: in-testsuite?
I was going to file a bug against this too, but found it would have been a dupe. Still seeing this behavior in firefox 3.0.10.
This will not be fixed for any Firefox 3.0.x release. There is a good chance to have it in the upcoming Firefox 3.5.
Comment on attachment 374427 [details] [diff] [review] patch a191, but I'd really like to see a test or a bug assigned to yourself to follow up with a test.
Attachment #374427 - Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
Verified fixed on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090515 Shiretoko/3.5b5pre ID:20090515030938
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: