Closed
Bug 486702
Opened 16 years ago
Closed 16 years ago
Library left pane not updated properly / dynamically
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
People
(Reporter: jmjjeffery, Assigned: mak)
References
Details
(Keywords: regression, verified1.9.1)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Open the Library
1. History - Show all History
2. In the right-pane - delete the 'today' folder
3. Note is disappears from the Left pane - Expected I would think
4. Now browse some and note that in the right pane the 'Today' folder is re-added showing your history, but the left pane does not have the 'Today' folder.
5. Close/reopen the History Library as in step 1, now you have the 'Today' folder.
Tested on Vista HP SP1 and today's nightly:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090403 Minefield/3.6a1pre Firefox/3.0.7 ID:20090403050211
Thanks to alice0755 in the builds forum:
http://forums.mozillazine.org/viewtopic.php?p=6168055#p6168055
Reporter | ||
Updated•16 years ago
|
Summary: Library left pane not updated properly → Library left pane not updated properly / dynamically
Comment 1•16 years ago
|
||
The re-added 'Today' folder in the right pane can not expand by dblclick until reopen the the History Library.
Updated•16 years ago
|
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•16 years ago
|
||
we were updating grouped queries only when they were roots, but in the left pane of the library they are simple children of a folder.
Attachment #371351 -
Flags: review?(dietrich)
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite?
Comment 3•16 years ago
|
||
Comment on attachment 371351 [details] [diff] [review]
patch v1.0
r=me, thanks
Attachment #371351 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 4•16 years ago
|
||
i simply added a null check on the observer, to be consistent with other observers (And because gc can do nice things to our no more used results)
Attachment #371351 -
Attachment is obsolete: true
Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Reporter | ||
Comment 6•16 years ago
|
||
Verified fixed using hourly build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090408 Minefield/3.6a1pre Firefox/3.0.7 ID:20090408072231
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 7•16 years ago
|
||
pushed as a merged patch with bug 422163
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/969eb6567510
Keywords: fixed1.9.1
Comment 8•16 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090414 Shiretoko/3.5b4pre
Keywords: fixed1.9.1 → verified1.9.1
Comment 9•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•