Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 16 years ago

The selection underlines -- spellchecker underline and IME selection underlines -- should displayed always. E.g., they shouldn't be clipped by the input element's border. And they shouldn't overlap to the text of next line.

We can use following approach:

1. If underline offset which comes from font metrics is lesser than zero, we can lift up the underline by ignoring the value.

2. If the underline style is double or wavy, we can reduce the underline rect without shrinking the line height. We can shrink the gap between the two lines at double style. And we can shrink the rect height to lineHeight * 2 at wavy style.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 1 • 16 years ago

Comment on attachment 370891 [details] [diff] [review]
Patch v1.0

+        // Don't shrunk the line height.  Because the thickness has some
+        // meaning.

"Don't shrink the line height, because the thickness has some meaning" (similar again down below)

+  PRBool liftupUnderline = aDescentLimit >= 0.0;

Call it "canLiftUnderline"

You might want to add a comment making it clear that for "double" style, you're just shrinking the gap.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 16 years ago

http://hg.mozilla.org/mozilla-central/rev/b14428284d51