Closed
Bug 487558
Opened 16 years ago
Closed 14 years ago
Use satchel notifications to track form data
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: Mardak, Assigned: philikon)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
The fix in bug 487541 reimplements the logic that satchel uses to decide if an input should be saved. Bug 487556 will provide the satchel notifications, so when that's fixed, we should use them in weave.
Updated•15 years ago
|
Target Milestone: -- → 1.0
Updated•15 years ago
|
Component: Weave → General
Product: Mozilla Labs → Weave
Version: Trunk → unspecified
Updated•15 years ago
|
QA Contact: weave → general
Updated•15 years ago
|
Component: General → Sync
QA Contact: general → sync
Target Milestone: 1.0 → ---
Reporter | ||
Updated•15 years ago
|
Target Milestone: --- → Future
Assignee | ||
Comment 2•14 years ago
|
||
We should
* nuke its Gecko 2.0 XPCOM registrations
* move it to the 'addon' directory
* make engines/form.js aware of the new-style notifications (while keeping
support for the old-style notifications as long as we support 3.5/3.6)
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> We should
> * nuke its Gecko 2.0 XPCOM registrations
> * move it to the 'addon' directory
> * make engines/form.js aware of the new-style notifications (while keeping
> support for the old-style notifications as long as we support 3.5/3.6)
it = FormNotifier.js
Assignee | ||
Comment 4•14 years ago
|
||
Made the form tracker listen to the 'satchel-storage-changed' notification which is sent by Firefox 4. That makes FormNotifier.js unnecessary on that platform, so moved it to the 'addon' directory and removed it from the manifest. The former means it will no longer be exported to mozilla-central. The latter means it will be disabled when the add-on is installed on Firefox 4.
(Note that the patch is against the patches from bug 584241.)
Assignee: nobody → philipp
Attachment #463209 -
Flags: review?(mconnor)
Updated•14 years ago
|
Attachment #463209 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•