Places depends on SUBSTR to treat the second parameter of 0 as the start of the string. However, 1 is supposed to be that. Before SQLite 3.6.11, SQLite let this pass, but it was a bug. We depended on it. This is a blocker because linux distributions generally use system SQLite, and they could upgrade to 3.6.11 or newer and break us. This needs to be fixed all the way back to 1.9.0 sadly :(

Comment on attachment 371906 [details] [diff] [review] v1.0 nit: would be nice to fix these to consistently use a space between parameters to functions in SQL, or to not. r=me

With nits addressed: http://hg.mozilla.org/mozilla-central/rev/4da51fbf7245

Comment on attachment 371906 [details] [diff] [review] v1.0 Maybe this patch will get approval before blocking for 1.9.0

Comment on attachment 371906 [details] [diff] [review] v1.0 Actually, I'd need to cook up a special branch patch, so I'll wait to see if this is wanted on branch

Not blocking but we'll approve the 1.9.0 patch when you have one.

Patch for 1.9.0.x

Comment on attachment 373672 [details] [diff] [review] branch v1.0 Approved for 1.9.0.10, a=dveditz for release-drivers

Checking in toolkit/components/places/src/nsNavHistory.cpp; new revision: 1.309; previous revision: 1.308 Checking in toolkit/components/places/src/nsNavHistoryExpire.cpp; new revision: 1.47; previous revision: 1.46

Verified fixed based on check-ins on trunk and 1.9.1. We have a test so lets turn the in-testsuite flag to +.