Closed
Bug 487781
Opened 16 years ago
Closed 16 years ago
5 sort operations required by FindVisits selectStatement
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: fixed1.9.1, perf)
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
with bug 481261 this query will warn due to the fact it cannot use an index to sort.
|
Assignee | |
Comment 1•16 years ago
|
||
dunno what i was thinking when i wrote the original query, could be sqlite has changed a lot lately, my new local tests are quite different.
This does not warn and is about 10x faster, hard to believe, i know.
|
||
Comment 2•16 years ago
|
||
Comment on attachment 373244 [details] [diff] [review]
patch v1.0
r=sdwilsh
Attachment #373244 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 373244 [details] [diff] [review]
patch v1.0
asking approval for a quite more efficient query, the query is used to find visits to expire.
Time of the query is reduced from about 200ms to about 20ms. Can potentially reduce TShutdown.
Attachment #373244 -
Flags: approval1.9.1?
|
|
||
Comment 5•16 years ago
|
||
And reduce CPU usage during idle expiration too!
|
||
Updated•16 years ago
|
Attachment #373244 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 373244 [details] [diff] [review]
patch v1.0
a191=beltzner
|
|
Assignee | |
Comment 7•16 years ago
|
||
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•