Closed
Bug 488042
Opened 16 years ago
Closed 15 years ago
disable XPCOM plugin loading
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(2 files, 3 obsolete files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
We need to remove XPCOM plugin support piece-by-piece and first we need to disable XPCOM plugin loading so we can start removing parts.
|
||
Comment 2•16 years ago
|
||
Comment on attachment 372309 [details] [diff] [review]
fix v1.0
- In nsPluginDirServiceProvider::GetFile():
+ nsresult rv;
This stray nsresult rv declaration (which you didn't add, just got moved) shadows the one that's returned from this method, and thus leaves the one being removed set incorrectly. This is causing the Java plugin loading problem on windows that you mentioned to me. This didn't use to be a problem because of the locality of the stray rv declaration prior to it being moved...
Attachment #372309 -
Attachment is obsolete: true
Attachment #372546 -
Flags: superreview?(jst)
|
|
||
Updated•15 years ago
|
Attachment #372546 -
Flags: superreview?(jst)
Attachment #372546 -
Flags: superreview+
Attachment #372546 -
Flags: review+
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 372546 [details] [diff] [review]
fix v1.1
r+sr=jst
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/7df4317278f5
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
backed out due to bug 491834
http://hg.mozilla.org/mozilla-central/rev/f2151b06463e
Don't load the OJI-based Java plugin on Windows. We should also blocklist it for > Gecko 1.9.1.
Attachment #372546 -
Attachment is obsolete: true
Attachment #377703 -
Flags: superreview?(jst)
|
|
||
Updated•15 years ago
|
Attachment #377703 -
Flags: superreview?(jst)
Attachment #377703 -
Flags: superreview+
Attachment #377703 -
Flags: review+
|
Assignee | |
Comment 10•15 years ago
|
||
Attachment #377703 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•15 years ago
|
||
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/7ff6eeaad3d1
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 12•15 years ago
|
||
backed out, strange unit test failure that I don't think is this but being safe (tests passed on the try server), I don't have time to watch the tree any more tonight
http://hg.mozilla.org/mozilla-central/rev/e720085bf9ba
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 13•15 years ago
|
||
Pushed to mozilla-central after Windows tboxes upgraded to Java SE 6 Update 14.
http://hg.mozilla.org/mozilla-central/rev/b15b92cb7b91
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•