Closed
Bug 488454
Opened 16 years ago
Closed 15 years ago
new icons for compose window toolbar for aero
Categories
(Thunderbird :: Message Compose Window, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: andreasn, Assigned: clarkbw)
References
Details
(Whiteboard: [no l10n impact])
Attachments
(5 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
philor
:
review+
clarkbw
:
ui-review+
standard8
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
Bug for tracking new icons for the compose window.
Reporter | ||
Comment 1•16 years ago
|
||
Reporter | ||
Comment 2•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Severity: normal → enhancement
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0rc1
Assignee | ||
Updated•16 years ago
|
Whiteboard: [needs patch]
Assignee | ||
Comment 3•16 years ago
|
||
we could probably wait on getting a format-buttons image for aero or drop this in now.
Assignee: nobody → clarkbw
Status: NEW → ASSIGNED
Assignee | ||
Updated•16 years ago
|
Whiteboard: [needs patch] → [has patch][needs review or new icon]
Reporter | ||
Comment 4•15 years ago
|
||
Here are the format icons. Using a more flat style on these, similar to what Windows Photo Gallery uses (and Firefox use for the navigation icons). This also don't show any icons for the sub items in the insert menu (similar to what other vista menus does).
Attachment #392685 -
Flags: ui-review?(clarkbw)
Reporter | ||
Comment 5•15 years ago
|
||
Assignee | ||
Comment 6•15 years ago
|
||
Comment on attachment 392685 [details] [diff] [review]
format icons and css as patch on trunk
Looks good, I like the flat style. I'd like to get philor to code review this as well.
There's enough difference between the two CSS files such that it seems reasonable to have two different ones for this.
Attachment #392685 -
Flags: ui-review?(clarkbw)
Attachment #392685 -
Flags: ui-review+
Attachment #392685 -
Flags: review?(philringnalda)
Comment 7•15 years ago
|
||
Call me picky, but I don't really like seeing a comment like "/* Lets see if this does something*/" - especially if it's for the prefs window, in a patch about the compose toolbar :)
Reporter | ||
Comment 8•15 years ago
|
||
Eeek, did I leave that in there?
Terribly sorry for that, will fix a new patch.
Reporter | ||
Comment 9•15 years ago
|
||
hope this works better. The other part that snuck in was from trying to fix #504042, but it turned out to be fixable from another place.
Comment 10•15 years ago
|
||
Comment on attachment 393540 [details] [diff] [review]
updated patch
thx - I probably could've removed it myself, but I figured you would be more likely than me to notice any other stray bits.
Attachment #393540 -
Flags: review?(philringnalda)
Updated•15 years ago
|
Attachment #392685 -
Attachment is obsolete: true
Attachment #392685 -
Flags: review?(philringnalda)
Updated•15 years ago
|
Attachment #381109 -
Attachment is obsolete: true
Comment 11•15 years ago
|
||
Comment on attachment 393540 [details] [diff] [review]
updated patch
Looks fine, other than all the trailing spaces and weird choices of blank-lines-or-not which came from the original - I think I fixed at least most of them before I pushed it.
Attachment #393540 -
Flags: review?(philringnalda) → review+
Comment 12•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Summary: new icons for compose window toolbar → new icons for compose window toolbar for aero
Whiteboard: [has patch][needs review or new icon]
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b4
Reporter | ||
Comment 13•15 years ago
|
||
Realized the toolbar images wasn't included in this patch, and hence not checked in. Patch for that coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 14•15 years ago
|
||
Here are the toolbar icons.
Attachment #401185 -
Flags: ui-review?(clarkbw)
Attachment #401185 -
Flags: review?(philringnalda)
Updated•15 years ago
|
Whiteboard: [no l10n impact]
Updated•15 years ago
|
Target Milestone: Thunderbird 3.0b4 → Thunderbird 3.0rc1
Updated•15 years ago
|
Attachment #401185 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 15•15 years ago
|
||
Comment on attachment 401185 [details] [diff] [review]
toolbar icons as patch
having problems with my build so I'll just plus this blindly and blame andreas for any issues later on :-P
Attachment #401185 -
Flags: ui-review?(clarkbw) → ui-review+
Updated•15 years ago
|
Attachment #401185 -
Flags: approval-thunderbird3?
Updated•15 years ago
|
Attachment #401185 -
Flags: approval-thunderbird3? → approval-thunderbird3+
Reporter | ||
Comment 16•15 years ago
|
||
(In reply to comment #15)
> (From update of attachment 401185 [details] [diff] [review])
> having problems with my build so I'll just plus this blindly and blame andreas
> for any issues later on :-P
Crap :)
Reporter | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 17•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•