Closed Bug 488682 Opened 16 years ago Closed 16 years ago

Remove unused blockedSite.properties file

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: johnath, Assigned: johnath)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Delete the file, remove the jar.mn entry
(deleted), patch
tony
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
This should have happened in bug 402370 but didn't. These strings aren't used anywhere any more, since the FF2 speech bubble code is gone, and the FF3 about:blocked implementation uses a DTD.
Attachment #373109 - Flags: review?(tony)
Attachment #373109 - Flags: review?(tony) → review+
Comment on attachment 373109 [details] [diff] [review] Delete the file, remove the jar.mn entry Looks good
http://hg.mozilla.org/mozilla-central/rev/5e143ccf604b
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #373109 - Flags: approval1.9.1?
Comment on attachment 373109 [details] [diff] [review] Delete the file, remove the jar.mn entry Just removes an unused properties file. No harm to not take it on branch, but I think it's virtuous to remove strings on branches that we're trying to get maximally localized, and once it has baked to ensure no build bustage, I see no risk.
Yes, this would be good to take on 1.9.1, post-B4 as soon as possible.
Comment on attachment 373109 [details] [diff] [review] Delete the file, remove the jar.mn entry a191 for post b4 as per Axel's instructions.
Attachment #373109 - Flags: approval1.9.1? → approval1.9.1+
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: