Closed
Bug 488824
Opened 16 years ago
Closed 15 years ago
Remove WIN16 (support) code, in js/src
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
Bug 438331 comment 28:
{{
From Serge Gautherie (:sgautherie) 2009-04-12 01:48:30 PDT
{
/js/src/liveconnect/jsj_hash.c
* line 133 -- #endif /* WIN16 */
* line 230 -- #endif /* WIN16 */
}
will be removed by bug 442399.
}}
|
||
Comment 1•15 years ago
|
||
Is this bug Fixed?
|
||
Comment 3•15 years ago
|
||
Serge, want to submit a patch? I can review and land it.
|
Assignee | |
Comment 4•15 years ago
|
||
Fwiw, this was not (entirely) true (anymore) anyway, due to 'jpeg3250':
http://mxr.mozilla.org/mozilla-central/search?string=%5B%5E_S%5DVERSION_NUMBER®exp=on&case=on
|
|
||
Updated•15 years ago
|
Attachment #390685 -
Flags: review?(gal) → review+
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 390685 [details] [diff] [review]
(Av1) 2 config.mk
[Checkin: Comment 5]
http://hg.mozilla.org/mozilla-central/rev/7accd82ab321
Attachment #390685 -
Attachment description: (Av1) 2 config.mk → (Av1) 2 config.mk
[Checkin: Comment 5]
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•15 years ago
|
||
Peter, could you look into jsOS240.def? (which is the last occurrence)
Assignee: sgautherie.bz → general
Status: ASSIGNED → NEW
Flags: in-testsuite-
|
||
Comment 7•15 years ago
|
||
Serge, jsOS240.def is obsolete (and apparently has been for years, since when is there no jsOS240.dll any more?), it doesn't even list the symbols with the currently used calling convention. And I can very well compile js/src without it. Please just remove that file.
|
|
Assignee | |
Comment 8•15 years ago
|
||
Per comment 7.
Assignee: general → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #390757 -
Flags: review?(mozilla)
|
|
||
Updated•15 years ago
|
Attachment #390757 -
Flags: review?(mozilla) → review+
|
|
Assignee | |
Comment 9•15 years ago
|
||
Comment on attachment 390757 [details] [diff] [review]
(Bv1) Remove jsOS240.def
[Checkin: Comment 9]
http://hg.mozilla.org/mozilla-central/rev/1f8bcac8854b
Attachment #390757 -
Attachment description: (Bv1) Remove jsOS240.def → (Bv1) Remove jsOS240.def
[Checkin: Comment 9]
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•