Currently there is a line between the folders in the folder pane, but neither Live Mail, (file) explorer or Firefox (in the bookmark library) does this. I suggest we use the same behavior for Thunderbird.

This also affects the message thread pane (well, everywhere basically), but I think that is a good thing.

Ok, here's the patch to remove the tree lines from Windows builds

Comment on attachment 377343 [details] [diff] [review] patch to remove tree lines when you're back on windows can you take a look at this patch?

people have gotten very unhappy in the past when we've removed the lines from the thread pane, since it makes it harder to figure out the reply hierarchy. I think getting rid of the lines in the folder pane produces a much cleaner look, and wouldn't be an issue. Would it be weird to get rid of the folder pane lines but not the thread pane lines? It does seem odd that changing folderPane.css would change threadPane as well.

David: yeah, I think that makes sense. Will fix up a patch that only affects the folder pane, as this was my main target.

(In reply to comment #4) > people have gotten very unhappy in the past when we've removed the lines from > the thread pane, since it makes it harder to figure out the reply hierarchy. Ok, though I think it's been gone from the Linux builds for a while now. > I think getting rid of the lines in the folder pane produces a much cleaner > look, and wouldn't be an issue. Would it be weird to get rid of the folder pane > lines but not the thread pane lines? It does seem odd that changing > folderPane.css would change threadPane as well. The css hierarchy is a little messed up in that aspect. I'm not sure how it was originally intended to work.

Comment on attachment 377343 [details] [diff] [review] patch to remove tree lines removing this until we get a new patch

This patch only removes the tree lines from the folder pane but leaves them in the thread list

We don't actually want tree lines in the folder pane on any platform, in any theme, so let's just kill http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWidgets.xml#1777 (and back out the over-aggressive Gnomestripe CSS, too, so we get them back in the thread pane).

Let's just pretend I didn't copy the mailWidgets.xml link, where I was idly wondering wtf we wanted treelines for, instead of http://mxr.mozilla.org/comm-central/source/mail/base/content/messenger.xul#209, and let's further pretend that I didn't then try out a patch with what I pasted instead of what I wanted :)

But, once you actually remove the attribute from the right file, it works. The downside is that it makes life difficult for a third-party theme that incomprehensibly wants to have treelines in the folder pane. The upside is that it makes life difficult for a third-party theme that incomprehensibly wants to have treelines in the folder pane :)

Comment on attachment 381104 [details] [diff] [review] remove tree lines from folderPane only nothing to see here

Comment on attachment 381232 [details] [diff] [review] Cut them off at the roots and the gnomestripe theme change ftw!

Comment on attachment 381232 [details] [diff] [review] Cut them off at the roots Looks good! r=mkmelin

(In reply to comment #11) >Cut them off at the roots > > But, once you actually remove the attribute from the right file, it works. > > The downside is that it makes life difficult for a third-party theme that > incomprehensibly wants to have treelines in the folder pane. We could wait for the inevitable Bug that will come from the the guy who has set up a complex local folder hierarchy, or we could find a better way. Personally, I don't mind the removal of treelines in the folderpane, but without the attribute, I don't think it's even possible to restore them using userChrome. xref bug 430852

Well, it took me two minutes to successfully do it in userChrome, mostly because I forgot that it was chrome/userChrome.css, and then I had to answer the phone, so let's wait and see rather than prepanicking.