Serge Gautherie (:sgautherie) Reporter
	Description • 15 years ago

Bug 484579 comment 21:
{
From  Serge Gautherie (:sgautherie)   2009-04-19 06:02:32 PDT

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239905472.1239917703.3668.gz&fulltext=1
Linux mozilla-central unit test on 2009/04/16 11:11:12

Leaked: 3328
}

	:Paolo Amadini Assignee
	Comment 1 • 15 years ago

The leaks observed in test_getTypeFromExtension_with_empty_Content_Type.js
are common to all the three exthandler tests, and are caused by the directory
service provider not being unregistered in head_handlerService.js.

This essential patch should solve the issue. There is still a leak in
test_punycodeURIs.js, but it seems to be caused by the nsEnvironment::Set
calls. I had a look at the code but can't find the leak at a glance, it's
better that someone else looks at it:

http://mxr.mozilla.org/mozilla-central/source/xpcom/threads/nsEnvironment.cpp#163

	Serge Gautherie (:sgautherie) Reporter
	Comment 2 • 15 years ago

(In reply to comment #1)
> common to all the three exthandler tests

That is good news!

> caused by the nsEnvironment::Set calls.

Must be bug 203764 ;-|

	Shawn Wilsher :sdwilsh
	Comment 3 • 15 years ago

Comment on attachment 373576 [details] [diff] [review]
Fix most leaks in exthandler tests
[Checkin: Comment 4 & 5]

r=sdwilsh

Technically, you need sr, but I'm not sure if anyone will actually care if you don't get it here.

	Serge Gautherie (:sgautherie) Reporter
	Comment 4 • 15 years ago

Comment on attachment 373576 [details] [diff] [review]
Fix most leaks in exthandler tests
[Checkin: Comment 4 & 5]


http://hg.mozilla.org/mozilla-central/rev/02d8a0a5f71f

	Serge Gautherie (:sgautherie) Reporter
	Comment 5 • 15 years ago

Comment on attachment 373576 [details] [diff] [review]
Fix most leaks in exthandler tests
[Checkin: Comment 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4c6223415d6f

	Serge Gautherie (:sgautherie) Reporter
	Comment 6 • 15 years ago

V.Fixed, per FF and TB tinderboxes.

Thanks Paolo!