Closed Bug 489828 Opened 16 years ago Closed 16 years ago

Clicking "Bookmark this page" or the star button a second time will not open Edit bookmark dialog

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: marcia, Unassigned)

References

Details

(Keywords: regression, verified1.9.1, Whiteboard: [fixed by subsequent checkins in bug 394759 ])

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090423 Minefield/3.6a1pre. Not seen running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.9) Gecko/2009040820 Firefox/3.0.9 STR: 1. Using a new profile, visit a site and click the star button. 2. The star changes to blue, but the dialog does not open allowing me to make further adjustments. No errors in the Error console or the Console app. No extensions installed in the profile. I also saw this on an existing profile Plugins: Gecko Default Flip4Mac 2.2.1 iPhotoPhotocast 7.0 JEP 0.9.7 Picasa 1.0 Quicktime 7.6 Flash 10.0.12.36 Shockwave Director 11.0.3r470 Hardware specs: Model Name: MacBook Model Identifier: MacBook4,1 Processor Name: Intel Core 2 Duo Processor Speed: 2.4 GHz Number Of Processors: 1 Total Number Of Cores: 2 L2 Cache: 3 MB Memory: 2 GB Machine has also been rebooted and the issue persists.
Flags: blocking-firefox3.5?
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.9) Gecko/2009040821 Firefox/3.0.9 FTR, I can't reproduce this. On first click the dialog isn't supposed to open, rather a bookmark is created. The second click should open. Is that what you were experiencing?
Yes, the second click does not open the dialog. Henrik cannot reproduce on his Mac machine. This is my personal machine that I also test on, and builds are updated to the latest nightly each day. Note that I am not using an external mouse to click, using the button behind the trackpad to initiate the click. (In reply to comment #1) > Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.9) Gecko/2009040821 > Firefox/3.0.9 > FTR, I can't reproduce this. On first click the dialog isn't supposed to open, > rather a bookmark is created. The second click should open. Is that what you > were experiencing?
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090423 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090423044103 has this.
Keywords: regression
OS: Mac OS X → All
Version: 3.5 Branch → Trunk
BuildID: 20090423040926 if the Mac build that I am seeing it on -> about:buildconfig shows it was built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2581ba72da24
Summary: Clicking Star button will not open Edit bookmark dialog → Clicking Star button second time will not open Edit bookmark dialog
It was a bumpy ride this morning but, if I followed along correctly, see bug 394759 comment #109
(In reply to comment #5) > It was a bumpy ride this morning but, if I followed along correctly, see bug > 394759 comment #109 Good point! I'm updating my build now to the latest m-c, will post the results!
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090423 Minefield/3.6a1pre (nightly) Broken Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090423 Minefield/3.6a1pre (latest-tip as of 1:30 EST rev f083055d319a) Works fine for me. So this was fixed by a later checkin, leaving this bug open to catch dupes and blocking status...
Blocks: 394759
Hardware: x86 → All
Whiteboard: [fixed by subsequent checkins in bug 394759 ]
in confirm, this worked in build 20090422 but broke on 20090423. Why was this not caught on unit tests last night? Please block beta 4 for this.
in my Error Console: Error: resource://gre/modules/PluralForm.jsm - Could not set symbol 'PluralForm' on target object. Source File: chrome://browser/content/browser.js Line: 6183
Doesn't this feature have an automated testcase?
Flags: in-testsuite?
Yes it does, right here: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_bug432599.js#20 I'm building a debug build now with the broken bits to see why the test failed.
This bug is fixed by now (m-c tip) see comment 7. It *was* caught by automated tests, see the comments towards the end of bug 394759. Just happened to be bad timing, and it got caught in a nightly in a broken state...
Clearing out |in-testsuite?| flag since we have one (and it probably already has a bug for its addition to the testsuite associated with it) -- thanks, Nochum!
Flags: in-testsuite?
To reiterate, this works for me on the latest 1.9.1 hourly build, as tested on Mac. Can we wait for a green cycle before marking as worksforme and clearing the flag?
This bug is valid and fixed (with a known fix). IMHO it shouldn't be closed until tomorrow's nightly so it can be tracked and to catch dupes. Just my .02. The whiteboard reflects exactly that (as does comment 7).
Nochum, I agree. For reference, this works in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre BuildID=20090423125909 http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/
That's not really how we use bugzilla... RESOLVED->FIXED means it's fixed on mozilla-central, which this is...
Tried comment #14, and verified fix on a Shiretoko hourly: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre. I think we're good here.
I catched the same with my Mozmill test for adding a bookmark via "Bookmarks|Bookmark this page". The dialog doesn't open there too. Updating summary. Meanwhile the 1.9.1 have been respinned and I can verify it with builds on OS X and Windows: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre ID:20090423163827 Lets resolve the bug and verify it on trunk as soon as new nighlies are available. And for sure sets the in-testsuite+ flag because we have a test for this regression already.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: verified1.9.1
Resolution: --- → FIXED
Summary: Clicking Star button second time will not open Edit bookmark dialog → Clicking "Bookmark this page" or the star button a second time will not open Edit bookmark dialog
Target Milestone: --- → Firefox 3.6a1
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Priority: -- → P2
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090425 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090425043745, V. Nothing seems to have popped up, so...
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.