Closed
Bug 490467
Opened 16 years ago
Closed 15 years ago
Play a sound when Download Completes (again)
Categories
(SeaMonkey :: Download & File Handling, defect)
SeaMonkey
Download & File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: neil)
References
Details
(Keywords: fixed-seamonkey2.0)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-seamonkey2.0+
|
Details | Diff | Splinter Review |
This is a very basic implementation (and still a WIP) of playing sounds when a download completes....
(formatting slightly funky as I just had to hand-edit a diff due to including part of the bits meant for here in another patch)
|
Assignee | |
Comment 1•16 years ago
|
||
You'd want to check the play sound pref every time you download for a start.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Since we can't reasonably expect Callek to finish the patch soon...
* Removed comment markers in pref-downloads.js
* Add code to disable sound controls on startup
* Uncommented elements in pref-downloads.xul (sadly not as easy as .js)
* Add code to nsSuiteGlue.js to actually play the sound
(very loosely based on Callek's patch)
Assignee: bugspam.Callek → neil
Attachment #374907 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #403863 -
Flags: review?(iann_bugzilla)
Comment on attachment 403863 [details] [diff] [review]
Proposed patch
You have a clash of accesskeys "a" is used in two places. You could change "Play a sound" to "P" and then have "Show an alert" as "S"
Attachment #403863 -
Flags: review?(iann_bugzilla) → review-
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #403863 -
Attachment is obsolete: true
Attachment #403905 -
Flags: review?(iann_bugzilla)
Attachment #403905 -
Flags: review?(iann_bugzilla)
Attachment #403905 -
Flags: review+
Attachment #403905 -
Flags: approval-seamonkey2.0+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Pushed changeset 16d24cd30915 to comm-central.
You need to log in
before you can comment on or make changes to this bug.
Description
•