Closed
Bug 490801
Opened 16 years ago
Closed 15 years ago
Win XP address book icons
Categories
(Thunderbird :: Address Book, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: andreasn, Assigned: clarkbw)
References
Details
Attachments
(3 files, 1 obsolete file)
address book icons, big toolbar
We need to take the the icons from the Tango theme and add them to the XP theme.
|
Reporter | |
Comment 1•16 years ago
|
||
|
|
Reporter | |
Comment 2•16 years ago
|
||
|
Assignee | |
Comment 3•16 years ago
|
||
here's the patch that does for winXP what we already did for Linux. I grabbed the tango version of icons where I was missing them and added menuitem-iconic to a couple of elements so I could get similar menuitem / popup items.
one more for the bienvenu queue on monday!
|
||
Comment 4•16 years ago
|
||
Should windows really use menu icons? At least i don't recall seeing any in firefox.
|
|
Reporter | |
Comment 5•16 years ago
|
||
Correct, the standard behavior on Windows is to not have any icons in menus.
|
|
Reporter | |
Comment 6•16 years ago
|
||
Correct, the standard behavior on Windows is to not have any icons in menus.
A quick lookover I did on Windows apps recently:
Internet Explorer 7: nope
Windows Media Player: nope
Outlook Express: nope
Notepad: nope
Spider Harpan: nope
File Explorer: nope
Office 2003: yes, for stuff that have toolbar icons.
|
||
Comment 7•16 years ago
|
||
Comment on attachment 377808 [details] [diff] [review]
addrbook patch
it's up to you if you want the menu icons or not, but they are appearing in the menus.
Attachment #377808 -
Flags: review?(bienvenu) → review+
|
|
Assignee | |
Comment 8•16 years ago
|
||
ok, lets hold off on the menu icons then. i can make up another patch that doesn't include the xul or css files.
|
|
Assignee | |
Comment 9•15 years ago
|
||
same patch w/ the xul and css files removed. I'll rerequest review just because I'm not too comfortable carrying it forward for this.
Attachment #377808 -
Attachment is obsolete: true
Attachment #378403 -
Flags: review?(bienvenu)
|
|
Assignee | |
Updated•15 years ago
|
Hardware: x86 → All
Whiteboard: [waiting on reivew :bienvenu]
|
|
||
Updated•15 years ago
|
Attachment #378403 -
Flags: review?(bienvenu) → review+
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [waiting on reivew :bienvenu]
|
||
Comment 10•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•