Closed
Bug 490817
Opened 15 years ago
Closed 15 years ago
Add about:rights link to Thunderbird's about:license page.
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
philor
:
review+
standard8
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
As Gerv mentioned in bug 480533 comment 4, we should have a line at the top of the about:license page that links to about:rights.
I'm not sure we really want to take this without getting our navigation of about: pages fixed - a bug which I'll file in a moment.
Assignee | ||
Comment 1•15 years ago
|
||
(In reply to comment #0)
> I'm not sure we really want to take this without getting our navigation of
> about: pages fixed - a bug which I'll file in a moment.
Bug 490817.
Erm, your app-license.html already lives at mail/app/app-license.html (see bug 428144), and I really don't think you want two different ones that you have to remember to keep in sync.
OTOH, you probably don't want '<a href="about:rights">Know your rights</a>.' in license.html, either, so, um....
(In reply to comment #2)
> OTOH, you probably don't want '<a href="about:rights">Know your rights</a>.' in
> license.html, either, so, um....
I suppose you could strip that sentence out in the Makefile rule that currently strips out the about:license parts of the links to anchors when processing license.html:
http://hg.mozilla.org/comm-central/annotate/6a18f69a13c2/mail/app/Makefile.in#l343
Or just stop shipping license.html entirely, if you're implementing internal viewers for about:license and friends….
Assignee | ||
Updated•15 years ago
|
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #2)
> Erm, your app-license.html already lives at mail/app/app-license.html (see bug
> 428144), and I really don't think you want two different ones that you have to
> remember to keep in sync.
I hadn't actually thought about that when I did this bug ages ago. Bug 519667 is going to remove that and license.html.
> OTOH, you probably don't want '<a href="about:rights">Know your rights</a>.' in
> license.html, either, so, um....
Yes we do. If I can fix bug 516776 then I can also make it so that users can click through that link. Hence, assuming I fix bug 516776 for TB 3 then I'll do this one as well.
(In reply to comment #4)
> (In reply to comment #2)
> > OTOH, you probably don't want '<a href="about:rights">Know your rights</a>.' in
> > license.html, either, so, um....
>
> Yes we do.
I meant the stand-alone license.html file there, where the user would have loaded the file in $RANDOM_BROWSER, not the jarred license.html accessed via about:license. I hadn't seen bug 519667 ;)
Anyway, ignore me and carry on :)
Assignee | ||
Comment 6•15 years ago
|
||
This depends on the patch in bug 519667. It also depends on bug 516776 going in (so that the link works).
This removes the old license.html (as originally discussed in bug 519667) and inserts the required text (same as FF) in our license that we can now access from the About dialog.
Assignee | ||
Comment 7•15 years ago
|
||
Comment on attachment 409068 [details] [diff] [review]
The fix v2
Phil, do you have time to review this? if not I'll pass to bienvenu or someone.
Attachment #409068 -
Flags: review?(philringnalda)
Updated•15 years ago
|
Attachment #409068 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 8•15 years ago
|
||
Comment on attachment 409068 [details] [diff] [review]
The fix v2
Giving a=me for my own patch as this is a low risk patch (significantly build-config only) that finishes off part of the license rework.
Although bug 516776 hasn't landed yet, it is blocking, so I will land something for it, which would at least make this link work properly.
Attachment #409068 -
Flags: approval-thunderbird3+
Assignee | ||
Comment 9•15 years ago
|
||
Checked in:
http://hg.mozilla.org/comm-central/rev/f810828f8ca1
http://hg.mozilla.org/releases/comm-1.9.1/rev/f1b37d88d156
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: helpwanted
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in
before you can comment on or make changes to this bug.
Description
•