> + // have already been reported here. I choose not too add it. i'm not sure if you want choose (present tense) or chose (past tense), however i know you want 'to' (verb marker), not 'too' (also). > + * @param lock An Mutex to associate with this condition variable. a, not an. ---- Your files which *seem* to be new cary copyright dates of 1998, i don't see a reason for this, could you explain why?

Courtesy of Benjamin: This caused 6 new warnings: http://office.smedbergs.us:8080/build?id=1391

(In reply to comment #0) > > + // have already been reported here. I choose not too add it. > > i'm not sure if you want choose (present tense) or chose (past tense), however > i know you want 'to' (verb marker), not 'too' (also). > This was deleted by the patch adding the new deadlock detector. > > + * @param lock An Mutex to associate with this condition variable. > > a, not an. > Fixed. > ---- > > Your files which *seem* to be new cary copyright dates of 1998, i don't see a > reason for this, could you explain why? A lot of this code is borrowed from nsAutoLock and friends. I don't know copyright law well enough to change these dates or owners. Please feel free to change them if it might be an issue.

Pushed http://hg.mozilla.org/mozilla-central/rev/ba18c5ef04d5 Chris Jones - bug 491462: fix some typos and compiler warnings in deadlock detector. r=bsmedberg