Max Kanat-Alexander Assignee
	Description • 15 years ago

Right now format_time will cause Bugzilla to die if you happen to give it a fractional seconds value greater than 59 (like 59.2). I talked to the author of DateTime, and he said that he's going to change DateTime to complain if you *ever* give it fractional seconds, so we have to make sure that format_time truncates any "seconds" values to an int().

	Frédéric Buclin
	Comment 2 • 15 years ago

In which cases do we pass fractional seconds to format_time()?

	Max Kanat-Alexander Assignee
	Comment 3 • 15 years ago

(In reply to comment #2)
> In which cases do we pass fractional seconds to format_time()?

  During email at least, apparently, since that's when I was getting the error. In any case, this prevents it from ever causing a problem instead of us having to track down every place that it happens, every time it happens.

  I suspect it just comes from using NOW() on Pg in a few places.

	Frédéric Buclin
	Comment 4 • 15 years ago

Comment on attachment 375935 [details] [diff] [review]
v1

Looks good. r=LpSolit

	Max Kanat-Alexander Assignee
	Comment 5 • 15 years ago

tip:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.89; previous revision: 1.88
done

3.4:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.86.2.3; previous revision: 1.86.2.2
done