[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090711 SeaMonkey/2.1a1pre] (home, optim default) (W2Ksp4) (http://hg.mozilla.org/mozilla-central/rev/47bfcd275ede +http://hg.mozilla.org/comm-central/rev/291cbe3374b9)

Comment on attachment 388171 [details] [diff] [review] (Av1) Just do it, plus followup fix for bug 485736 [Checkin: See comment 3 & 4] + print "TEST-UNEXPECTED-FAIL | runxpcshelltests.py | No tests actually run. Did you pass an invalid --test-path?" Nit: drop the "actually".

Comment on attachment 388171 [details] [diff] [review] (Av1) Just do it, plus followup fix for bug 485736 [Checkin: See comment 3 & 4] http://hg.mozilla.org/mozilla-central/rev/a660f30cca18 Av1, with comment 2 suggestion(s).

Comment on attachment 388171 [details] [diff] [review] (Av1) Just do it, plus followup fix for bug 485736 [Checkin: See comment 3 & 4] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/83d2f8008e67 (Av1a-191) Just do it, plus followup fix for bug 485736 after fixing context for { patching file config/rules.mk Hunk #1 FAILED at 173 1 out of 1 hunks FAILED patching file js/src/config/rules.mk Hunk #1 FAILED at 173 1 out of 1 hunks FAILED patching file testing/testsuite-targets.mk Hunk #1 FAILED at 92 1 out of 1 hunks FAILED patching file testing/xpcshell/runxpcshelltests.py Hunk #1 succeeded at 73 with fuzz 1 (offset -10 lines). Hunk #3 FAILED at 232 Hunk #4 FAILED at 253 2 out of 4 hunks FAILED }

V.Fixed, per tinderboxes. Example: { INFO | Result summary: INFO | Passed: 588 INFO | Failed: 0 }

verified1.9.1.3, per tinderboxes. Example: { INFO | Result summary: INFO | Passed: 557 INFO | Failed: 0 [...] TinderboxPrint: xpcshell<br/>557/0 } *** And it's reporting the same count as the current buildbot log parser, then we can use the new summary in the latter with no worry :-)

(In reply to comment #6) > then we can use the new summary in the latter with no worry :-) And it also fixes the error cases, as expected: { INFO | Result summary: INFO | Passed: 646 INFO | Failed: 1 gmake[1]: *** [xpcshell-tests] Error 1 [...] TinderboxPrint: xpcshell-tests<br/>662/<em class="testfail">2</em> } The additional (and unwanted) counts from the buildbot log parser are due to the test log which is copied to the output on error.

(Sorry, I forgot about that :-/) *2 s/test/test-path/. *Fix indentation while there. *Fix a sync' nit with m-1.9.1.

Comment on attachment 397264 [details] [diff] [review] (Bv1-CC) followup fix for bug 485736 [Checkin: Comment 10] >+# What that one for? Unrelated?

Comment on attachment 397264 [details] [diff] [review] (Bv1-CC) followup fix for bug 485736 [Checkin: Comment 10] http://hg.mozilla.org/comm-central/rev/b12740c6606a (In reply to comment #9) > What that one for? Unrelated? Yes: "Fix a sync' nit with m-1.9.1."