Closed Bug 491972 Opened 16 years ago Closed 15 years ago

error building SimpleTypeLib.c due to perror() call

Categories

(Core :: XPCOM, defect)

ARM
Windows Mobile 6 Professional
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: jmaher, Assigned: hiro)

References

Details

Attachments

(1 file, 1 obsolete file)

On the #WINCE platform, we don't have perror() available to us as seen here: http://mxr.mozilla.org/mozilla-central/source/xpcom/typelib/xpt/tests/SimpleTypeLib.c#162 and we need to use something like: fprintf(stderr, "FAILED: fopen");
Attached patch Proposed patch (obsolete) (deleted) — Splinter Review
Declare perror with FormatMessage and GetLastError for WINCE.
Assignee: nobody → ikezoe
Status: NEW → ASSIGNED
Attachment #376345 - Flags: review?(benjamin)
If build is successful, the built binary will not work correctly since WINCE needs wmain function.
Thanks for pointing that out. My initial goal is to get things building, but will need them to run. I like your approach here to create a stable version of perror(...). Lets continue with this patch to include the wmain. I would like to get blassey's feedback on the general approach we should take for wmain.
(In reply to comment #3) > Lets continue with this patch to include the wmain. I would like to get > blassey's feedback on the general approach we should take for wmain. IMHO, we should open a new bug about wmain issue for WINCE.
Attached patch Revised patch (deleted) — Splinter Review
I missed a void.
Attachment #376345 - Attachment is obsolete: true
Attachment #376384 - Flags: review?(benjamin)
Attachment #376345 - Flags: review?(benjamin)
Attachment #376384 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
we should get this checked in. Getting the tests to build allows us to test with a lot of other tests. Fixing the few programs that depend on wmain only limit a few specific tests.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with 1.9.2 build and winmo alpha3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: