Closed
Bug 492231
Opened 16 years ago
Closed 16 years ago
Inconsistent bidi with dynamic "direction: rtl;" on iso-8859-8 (visual order) page
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: smontagu)
References
Details
(Keywords: fixed1.9.1, testcase)
Attachments
(4 files)
|
(deleted),
text/html; charset=iso-8859-8
|
Details | |
|
(deleted),
text/html; charset=iso-8859-8
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
The testcase and reference have the same final DOM, so they should look the same.
This bug only happens with the iso-8859-8 charset, so I suspect it has something to do with the "mIsVisual" member of nsPresContext being set to true.
|
Reporter | |
Comment 1•16 years ago
|
||
|
|
Reporter | |
Updated•16 years ago
|
Attachment #376594 -
Attachment mime type: text/html → text/html; charset=iso-8859-8
|
|
Reporter | |
Updated•16 years ago
|
Attachment #376593 -
Attachment mime type: text/html → text/html; charset=iso-8859-8
|
Assignee | |
Comment 2•16 years ago
|
||
This was exposed by bug 332655, but it's really a consequence of special casing frame placement for visual RTL instead of using the regular bidi frame reordering code.
Assignee: nobody → smontagu
Attachment #376636 -
Flags: superreview?(roc)
Attachment #376636 -
Flags: review?(roc)
Attachment #376636 -
Flags: superreview?(roc)
Attachment #376636 -
Flags: superreview+
Attachment #376636 -
Flags: review?(roc)
Attachment #376636 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Comment 4•16 years ago
|
||
This checkin introduced one new warning:
mozilla/layout/generic/nsLineLayout.cpp:2488: warning: unused variable ‘maxX’
due to removing all uses of 'maxX' without removing the variable declaration.
Can we remove the declaration for this now-unused variable in a followup patch, to fix this warning?
|
|
Assignee | |
Comment 5•16 years ago
|
||
Thanks for catching that! Removing the declaration allows some further code simplification.
Attachment #376849 -
Flags: superreview?(roc)
Attachment #376849 -
Flags: review?(roc)
Attachment #376849 -
Flags: superreview?(roc)
Attachment #376849 -
Flags: superreview+
Attachment #376849 -
Flags: review?(roc)
Attachment #376849 -
Flags: review+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Fix for the warning checked in in http://hg.mozilla.org/mozilla-central/rev/61b4f75f175a
|
|
Assignee | |
Comment 7•16 years ago
|
||
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•