Closed
Bug 492239
Opened 15 years ago
Closed 11 years ago
Removing "-moz-stack-sizing: ignore" does not work properly
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jruderman, Assigned: heycam)
References
Details
(Keywords: testcase)
Attachments
(3 files)
The testcase and reference should look the same (since they have the same DOM tree). -moz-stack-sizing was added in bug 346189. refdyn found this bug while playing with that bug's reftest.
Reporter | ||
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
This should be a one-liner in nsStyleXUL::CalcDifference (need to check mStretchStack).
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Comment on attachment 823185 [details] [diff] [review] patch >+ if (mStretchStack != aOther.mStretchStack) >+ return NS_CombineHint(nsChangeHint_NeedReflow, >+ nsChangeHint_ClearAncestorIntrinsics); > return NS_STYLE_HINT_REFLOW; You should omit this insertion, since NS_STYLE_HINT_REFLOW subsumes the above (and you might have other pieces !=). That said, we should probably produce finer hints for some of these, and in fact this mistake might not actually introduce any bugs, but that's probably outside the scope of this bug. r=dbaron with that
Attachment #823185 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f42b203a044
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4f42b203a044
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•