Closed Bug 492239 Opened 15 years ago Closed 11 years ago

Removing "-moz-stack-sizing: ignore" does not work properly

Categories

(Core :: XUL, defect)

x86
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jruderman, Assigned: heycam)

References

Details

(Keywords: testcase)

Attachments

(3 files)

Attached file testcase (dynamic) (deleted) —
The testcase and reference should look the same (since they have the same DOM tree).

-moz-stack-sizing was added in bug 346189.  refdyn found this bug while playing with that bug's reftest.
Attached file reference (static) (deleted) —
This should be a one-liner in nsStyleXUL::CalcDifference (need to check mStretchStack).
Attached patch patch (deleted) — Splinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #823185 - Flags: review?(dbaron)
Comment on attachment 823185 [details] [diff] [review]
patch

>+  if (mStretchStack != aOther.mStretchStack)
>+    return NS_CombineHint(nsChangeHint_NeedReflow,
>+                          nsChangeHint_ClearAncestorIntrinsics);
>   return NS_STYLE_HINT_REFLOW;

You should omit this insertion, since NS_STYLE_HINT_REFLOW subsumes the above (and you might have other pieces !=).  That said, we should probably produce finer hints for some of these, and in fact this mistake might not actually introduce any bugs, but that's probably outside the scope of this bug.

r=dbaron with that
Attachment #823185 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/4f42b203a044
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: